From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12228 invoked by alias); 12 Jun 2013 10:26:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12205 invoked by uid 89); 12 Jun 2013 10:26:47 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 12 Jun 2013 10:26:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6A7972E8DD; Wed, 12 Jun 2013 06:26:44 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9qmYaOIqUXdC; Wed, 12 Jun 2013 06:26:44 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 31BC92E85E; Wed, 12 Jun 2013 06:26:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D22B0C2B3C; Wed, 12 Jun 2013 14:26:42 +0400 (RET) Date: Wed, 12 Jun 2013 11:57:00 -0000 From: Joel Brobecker To: Will Newton Cc: Andrew Pinski , "gdb-patches@sourceware.org" , Patch Tracking Subject: Re: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads. Message-ID: <20130612102642.GO3969@adacore.com> References: <51B22910.7010208@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-06/txt/msg00271.txt.bz2 > > I think this should be an debian/Ubuntu local only patch as the > > default for FSF GCC/binutils is not to pass --as-needed. > > I admit the change is a little, erm, weird, but my hope was to avoid > causing pain to people who build gdb on Ubuntu. This isn't just Ubunto > or Debian developers but Ubuntu or Debian users that happen to have > downloaded a gdb tarball from gnu.org. Similar test failures in > binutils have been worked around by adding -Wl,--no-as-needed which we > could also do here, but I was concerned that this may break non-gcc > compilers. I tend to agree that it can be potentially useful, and since it does not appear to be very disruptive, I find it acceptable in principle. I just haven't had time to look into it in more details... -- Joel