From: Hui Zhu <teawater@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Yao Qi <yao@codesourcery.com>,
gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>,
lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [PATCH 3/5] Read CTF by the ctf target
Date: Fri, 01 Mar 2013 02:38:00 -0000 [thread overview]
Message-ID: <CANFwon2TPo1X2cUXXdzDEnX3UPvG2w0ZNMpNGN=KoDdBvyXLFQ@mail.gmail.com> (raw)
In-Reply-To: <512F9182.3080104@redhat.com>
On Fri, Mar 1, 2013 at 1:18 AM, Pedro Alves <palves@redhat.com> wrote:
> (not a complete review)
>
> On 02/27/2013 02:17 AM, Yao Qi wrote:
>
>> +if test "x$with_babeltrace" != "xno"; then
>> + saved_CFLAGS="$CFLAGS"
>> + CFLAGS="$CFLAGS $btinc"
>> + AC_MSG_CHECKING([for babeltrace])
>> + AC_TRY_COMPILE([
>> +#include <babeltrace/babeltrace.h>
>> +#include <babeltrace/ctf/events.h>
>> +#include <babeltrace/ctf/iterator.h>
>
> We know from previous patches that the latest released
> babeltrace breaks gdb, due to the lookup_enum function. Does
> this catch that? I see namespacing fixes going into
> babeltrace as recently as last 15th. Do we know if
> babeltrace's API is more or less done and close to a release?
Hi Mathieu,
Could you help us with this question?
Thanks,
Hui
>
>> + ],[],
>> + [AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBBABELTRACE, 1, [Define if libbabeltrace is available])],
>> + [AC_MSG_RESULT([no]); btlibs= ; btinc= ])
>> + CFLAGS="$saved_CFLAGS"
>> +fi
>> +
>> +# Flags needed for UST
>
> babeltrace
>
>> +AC_SUBST(btlibs)
>> +AC_SUBST(btinc)
>> +
>
> --
> Pedro Alves
>
next prev parent reply other threads:[~2013-03-01 2:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 2:18 [PATCH 0/5, 2nd try] CTF Support Yao Qi
2013-02-27 2:18 ` [PATCH 1/5] Refactor 'tsave' Yao Qi
2013-02-28 16:49 ` Pedro Alves
2013-03-01 8:58 ` Yao Qi
2013-03-01 10:05 ` Pedro Alves
2013-03-01 10:41 ` Pedro Alves
2013-03-01 11:26 ` Yao Qi
2013-03-01 12:13 ` Pedro Alves
2013-03-01 15:55 ` Yao Qi
2013-03-05 20:59 ` Pedro Alves
2013-03-03 8:45 ` Yao Qi
2013-02-27 2:19 ` [PATCH 5/5] ctf test: report.exp Yao Qi
2013-02-27 18:48 ` Pedro Alves
2013-02-28 1:36 ` Yao Qi
2013-02-28 18:30 ` Pedro Alves
2013-02-27 2:19 ` [PATCH 3/5] Read CTF by the ctf target Yao Qi
2013-02-28 17:59 ` Pedro Alves
2013-03-01 2:38 ` Hui Zhu [this message]
2013-05-07 13:07 ` Mathieu Desnoyers
2013-05-07 13:24 ` Yao Qi
2013-05-07 13:28 ` Mathieu Desnoyers
2013-03-01 7:55 ` Yao Qi
2013-03-01 9:15 ` Pedro Alves
2013-03-01 15:51 ` Tom Tromey
2013-03-03 10:39 ` Yao Qi
2013-03-03 10:46 ` Yao Qi
2013-02-27 2:19 ` [PATCH 2/5] Save trace into CTF format Yao Qi
2013-02-28 13:17 ` Yao Qi
2013-02-28 13:17 ` Andreas Schwab
2013-02-28 17:19 ` Pedro Alves
2013-03-01 19:22 ` Tom Tromey
2013-03-03 10:19 ` Yao Qi
2013-03-07 21:29 ` Tom Tromey
2013-03-16 2:30 ` Joel Brobecker
2013-03-16 4:22 ` Yao Qi
2013-02-27 2:19 ` [PATCH 4/5] ctf doc and NEWS Yao Qi
2013-02-27 18:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANFwon2TPo1X2cUXXdzDEnX3UPvG2w0ZNMpNGN=KoDdBvyXLFQ@mail.gmail.com' \
--to=teawater@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=palves@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox