From: Pedro Alves <palves@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Save trace into CTF format
Date: Thu, 28 Feb 2013 17:19:00 -0000 [thread overview]
Message-ID: <512F8F56.408@redhat.com> (raw)
In-Reply-To: <mvmvc9cr7xn.fsf@hawking.suse.de>
On 02/28/2013 11:31 AM, Andreas Schwab wrote:
> Yao Qi <yao@codesourcery.com> writes:
>
>> On 02/27/2013 10:17 AM, Yao Qi wrote:
>>> +static void
>>> +ctf_write_frame_v_block (struct trace_file_writer *self,
>>> + int num, LONGEST val)
>>> +{
>>> + struct ctf_writer_data *data = self->data;
>>> + int one = 1;
>>> +
>>> + /* Event Id. */
>>> + ctf_save_align_write (&data->tcs, (void *) &one, 4, 4);
>>
>> "&one" should be cast to "gdb_byte *" instead of "void *".
>
> Either one should be int32_t, or 4 should be sizeof (one).
And what about endianness?
--
Pedro Alves
next prev parent reply other threads:[~2013-02-28 17:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 2:18 [PATCH 0/5, 2nd try] CTF Support Yao Qi
2013-02-27 2:18 ` [PATCH 1/5] Refactor 'tsave' Yao Qi
2013-02-28 16:49 ` Pedro Alves
2013-03-01 8:58 ` Yao Qi
2013-03-01 10:05 ` Pedro Alves
2013-03-01 10:41 ` Pedro Alves
2013-03-01 11:26 ` Yao Qi
2013-03-01 12:13 ` Pedro Alves
2013-03-01 15:55 ` Yao Qi
2013-03-05 20:59 ` Pedro Alves
2013-03-03 8:45 ` Yao Qi
2013-02-27 2:19 ` [PATCH 5/5] ctf test: report.exp Yao Qi
2013-02-27 18:48 ` Pedro Alves
2013-02-28 1:36 ` Yao Qi
2013-02-28 18:30 ` Pedro Alves
2013-02-27 2:19 ` [PATCH 4/5] ctf doc and NEWS Yao Qi
2013-02-27 18:39 ` Eli Zaretskii
2013-02-27 2:19 ` [PATCH 2/5] Save trace into CTF format Yao Qi
2013-02-28 13:17 ` Yao Qi
2013-02-28 13:17 ` Andreas Schwab
2013-02-28 17:19 ` Pedro Alves [this message]
2013-03-01 19:22 ` Tom Tromey
2013-03-03 10:19 ` Yao Qi
2013-03-07 21:29 ` Tom Tromey
2013-03-16 2:30 ` Joel Brobecker
2013-03-16 4:22 ` Yao Qi
2013-02-27 2:19 ` [PATCH 3/5] Read CTF by the ctf target Yao Qi
2013-02-28 17:59 ` Pedro Alves
2013-03-01 2:38 ` Hui Zhu
2013-05-07 13:07 ` Mathieu Desnoyers
2013-05-07 13:24 ` Yao Qi
2013-05-07 13:28 ` Mathieu Desnoyers
2013-03-01 7:55 ` Yao Qi
2013-03-01 9:15 ` Pedro Alves
2013-03-01 15:51 ` Tom Tromey
2013-03-03 10:39 ` Yao Qi
2013-03-03 10:46 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F8F56.408@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@suse.de \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox