From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98899-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20526 invoked by alias); 28 Feb 2013 17:09:57 -0000
Received: (qmail 20516 invoked by uid 22791); 28 Feb 2013 17:09:56 -0000
X-SWARE-Spam-Status: No, hits=-8.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 17:09:46 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1SH9iU5018967	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 28 Feb 2013 12:09:44 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1SH9gJO007689;	Thu, 28 Feb 2013 12:09:43 -0500
Message-ID: <512F8F56.408@redhat.com>
Date: Thu, 28 Feb 2013 17:19:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Andreas Schwab <schwab@suse.de>
CC: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Save trace into CTF format
References: <1361931459-3953-1-git-send-email-yao@codesourcery.com>	<1361931459-3953-3-git-send-email-yao@codesourcery.com>	<512F38CE.5030802@codesourcery.com> <mvmvc9cr7xn.fsf@hawking.suse.de>
In-Reply-To: <mvmvc9cr7xn.fsf@hawking.suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00749.txt.bz2

On 02/28/2013 11:31 AM, Andreas Schwab wrote:
> Yao Qi <yao@codesourcery.com> writes:
> 
>> On 02/27/2013 10:17 AM, Yao Qi wrote:
>>> +static void
>>> +ctf_write_frame_v_block (struct trace_file_writer *self,
>>> +			 int num, LONGEST val)
>>> +{
>>> +  struct ctf_writer_data *data = self->data;
>>> +  int one = 1;
>>> +
>>> +  /* Event Id.  */
>>> +  ctf_save_align_write (&data->tcs, (void *) &one, 4, 4);
>>
>> "&one" should be cast to "gdb_byte *" instead of "void *".
> 
> Either one should be int32_t, or 4 should be sizeof (one).

And what about endianness?

-- 
Pedro Alves