From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Save trace into CTF format
Date: Sat, 16 Mar 2013 02:30:00 -0000 [thread overview]
Message-ID: <20130315234448.GA13624@adacore.com> (raw)
In-Reply-To: <51332381.6010101@codesourcery.com>
> 2013-03-03 Hui Zhu <hui_zhu@mentor.com>
> Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (REMOTE_OBS): Add ctf.o.
> (SFILES): Add ctf.c.
> (HFILES_NO_SRCDIR): Add ctf.h.
> * ctf.c, ctf.h: New files.
> * tracepoint.c : Include 'ctf.h'.
> (collect_pseudocommand): Remove static.
> (trace_save_command): Parse option "-ctf".
> Produce different trace file writers per option.
> Adjust output message.
> (trace_save_tfile, trace_save_ctf): New.
> * tracepoint.h (trace_save_tfile, trace_save_ctf): Declare.
> * mi/mi-main.c: Include 'ctf.h'.
> (mi_cmd_trace_save): Handle option '-ctf'. Call either
> trace_save_tfile or trace_save_ctf.
[...]
> + ctf_save_fwrite_format (handler->metadata_fd, metadata_fmt,
> + CTF_SAVE_MAJOR, CTF_SAVE_MINOR,
> + BYTE_ORDER == LITTLE_ENDIAN ? "le" : "be");
This is causing a build failure on ppc-aix, for instance, due to:
/[...]ctf.c:223:28: error: 'BYTE_ORDER' undeclared (first use in this function)
/[...]ctf.c:223:28: note: each undeclared identifier is reported only once for each function it appears in
/[...]ctf.c:223:42: error: 'LITTLE_ENDIAN' undeclared (first use in this function)
I don't know how to fix this, because I am not sure whether host
or target endianness were meant. I asssume from the code that it
was host, but not sure how the host endianess would make sense...
What also worries me is that I don't seem to see approval for commit
for this patch. I know both of you are very careful, so perhaps in
a separate message not linked to this sub-thread?
--
Joel
next prev parent reply other threads:[~2013-03-15 23:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 2:18 [PATCH 0/5, 2nd try] CTF Support Yao Qi
2013-02-27 2:18 ` [PATCH 1/5] Refactor 'tsave' Yao Qi
2013-02-28 16:49 ` Pedro Alves
2013-03-01 8:58 ` Yao Qi
2013-03-01 10:05 ` Pedro Alves
2013-03-01 10:41 ` Pedro Alves
2013-03-01 11:26 ` Yao Qi
2013-03-01 12:13 ` Pedro Alves
2013-03-01 15:55 ` Yao Qi
2013-03-05 20:59 ` Pedro Alves
2013-03-03 8:45 ` Yao Qi
2013-02-27 2:19 ` [PATCH 3/5] Read CTF by the ctf target Yao Qi
2013-02-28 17:59 ` Pedro Alves
2013-03-01 2:38 ` Hui Zhu
2013-05-07 13:07 ` Mathieu Desnoyers
2013-05-07 13:24 ` Yao Qi
2013-05-07 13:28 ` Mathieu Desnoyers
2013-03-01 7:55 ` Yao Qi
2013-03-01 9:15 ` Pedro Alves
2013-03-01 15:51 ` Tom Tromey
2013-03-03 10:39 ` Yao Qi
2013-03-03 10:46 ` Yao Qi
2013-02-27 2:19 ` [PATCH 4/5] ctf doc and NEWS Yao Qi
2013-02-27 18:39 ` Eli Zaretskii
2013-02-27 2:19 ` [PATCH 2/5] Save trace into CTF format Yao Qi
2013-02-28 13:17 ` Yao Qi
2013-02-28 13:17 ` Andreas Schwab
2013-02-28 17:19 ` Pedro Alves
2013-03-01 19:22 ` Tom Tromey
2013-03-03 10:19 ` Yao Qi
2013-03-07 21:29 ` Tom Tromey
2013-03-16 2:30 ` Joel Brobecker [this message]
2013-03-16 4:22 ` Yao Qi
2013-02-27 2:19 ` [PATCH 5/5] ctf test: report.exp Yao Qi
2013-02-27 18:48 ` Pedro Alves
2013-02-28 1:36 ` Yao Qi
2013-02-28 18:30 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315234448.GA13624@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox