From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98924-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31291 invoked by alias); 1 Mar 2013 02:38:13 -0000
Received: (qmail 31008 invoked by uid 22791); 1 Mar 2013 02:38:12 -0000
X-SWARE-Spam-Status: No, hits=-4.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-oa0-f41.google.com (HELO mail-oa0-f41.google.com) (209.85.219.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 02:38:07 +0000
Received: by mail-oa0-f41.google.com with SMTP id i10so5004449oag.0        for <gdb-patches@sourceware.org>; Thu, 28 Feb 2013 18:38:06 -0800 (PST)
X-Received: by 10.60.18.136 with SMTP id w8mr7538984oed.84.1362105486735; Thu, 28 Feb 2013 18:38:06 -0800 (PST)
MIME-Version: 1.0
Received: by 10.60.130.231 with HTTP; Thu, 28 Feb 2013 18:37:26 -0800 (PST)
In-Reply-To: <512F9182.3080104@redhat.com>
References: <1361931459-3953-1-git-send-email-yao@codesourcery.com> <1361931459-3953-4-git-send-email-yao@codesourcery.com> <512F9182.3080104@redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Fri, 01 Mar 2013 02:38:00 -0000
Message-ID: <CANFwon2TPo1X2cUXXdzDEnX3UPvG2w0ZNMpNGN=KoDdBvyXLFQ@mail.gmail.com>
Subject: Re: [PATCH 3/5] Read CTF by the ctf target
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org, 	Pedro Alves <palves@redhat.com>, lttng-dev <lttng-dev@lists.lttng.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00000.txt.bz2

On Fri, Mar 1, 2013 at 1:18 AM, Pedro Alves <palves@redhat.com> wrote:
> (not a complete review)
>
> On 02/27/2013 02:17 AM, Yao Qi wrote:
>
>> +if test "x$with_babeltrace" != "xno"; then
>> +  saved_CFLAGS="$CFLAGS"
>> +  CFLAGS="$CFLAGS $btinc"
>> +  AC_MSG_CHECKING([for babeltrace])
>> +  AC_TRY_COMPILE([
>> +#include <babeltrace/babeltrace.h>
>> +#include <babeltrace/ctf/events.h>
>> +#include <babeltrace/ctf/iterator.h>
>
> We know from previous patches that the latest released
> babeltrace breaks gdb, due to the lookup_enum function.  Does
> this catch that?  I see namespacing fixes going into
> babeltrace as recently as last 15th.  Do we know if
> babeltrace's API is more or less done and close to a release?

Hi Mathieu,

Could you help us with this question?

Thanks,
Hui

>
>> +  ],[],
>> +  [AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBBABELTRACE, 1, [Define if libbabeltrace is available])],
>> +  [AC_MSG_RESULT([no]); btlibs= ; btinc= ])
>> +  CFLAGS="$saved_CFLAGS"
>> +fi
>> +
>> +# Flags needed for UST
>
> babeltrace
>
>> +AC_SUBST(btlibs)
>> +AC_SUBST(btinc)
>> +
>
> --
> Pedro Alves
>