Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: contribution checklist in the wiki
Date: Mon, 20 May 2013 10:22:00 -0000	[thread overview]
Message-ID: <CANFwon1z0cNNsFDQmStrqR1awj8dejyRAMmqPN8Dy1xyKoRBiQ@mail.gmail.com> (raw)
In-Reply-To: <51965CE3.4020805@redhat.com>

Hi Pedro,

Thanks for you works.


I have a question about format of changelog:
2013-12-12  John Doe  <johndoe@some.email.address>

        PR gdb/9999

        * breakpoint.c (handle_some_event): Remove reference to<line
wrap at or before column 79>

If I remember is right, some people told me that there should not have
a empty line after "PR xxx".
And I checked the changelog, some of them have empty line and others don't have.

So does it need a empty line after "PR xxx"?


And I have another question is about [RFC].  Where should it be sent
to, gdb or gdb-patches?

Best,
Hui

On Sat, May 18, 2013 at 12:37 AM, Pedro Alves <palves@redhat.com> wrote:
> Guys,
>
> I've created a new page in the wiki:
>
>  http://sourceware.org/gdb/wiki/ContributionChecklist
>
> This was heavily borrowed from glibc's own contribution checklist.
> (I asked them if they were okay before doing it.)
>
> At present, some of the info there duplicates what gdb/CONTRIBUTE
> says (but in different wording).  I expect it to grow some, and I'd
> rather keep it dynamic, without formal review/checking steps, which
> IMO for this sort of think is a too heavy process.
> I tailored the original text to make it fitter for gdb, but it's
> possible/likely there are things that need more editing to make
> it even fitter.
>
> I've been noticing that I often find myself pointing at the same
> little mistakes over different submissions.  E.g., pointing at
> need to mention changes in NEWS.  As I notice these patterns, I'll
> add them to the wiki.  I invite others to do the same.
>
> Thanks,
> --
> Pedro Alves


  parent reply	other threads:[~2013-05-20 10:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 16:37 Pedro Alves
2013-05-20 10:06 ` Joel Brobecker
2013-05-20 15:14   ` Pedro Alves
2013-05-21  5:26     ` Joel Brobecker
2013-05-21 17:55       ` Pedro Alves
2013-05-22  6:29         ` Joel Brobecker
2013-05-22 10:12           ` Pedro Alves
2013-05-22 10:23             ` Joel Brobecker
2013-05-22 10:38               ` Pedro Alves
2013-05-22 10:50                 ` Joel Brobecker
2013-05-22 14:56         ` Eli Zaretskii
2013-05-20 10:22 ` Hui Zhu [this message]
2013-05-20 14:44   ` Pedro Alves
2013-05-20 17:02     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANFwon1z0cNNsFDQmStrqR1awj8dejyRAMmqPN8Dy1xyKoRBiQ@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox