Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: contribution checklist in the wiki
Date: Tue, 21 May 2013 05:26:00 -0000	[thread overview]
Message-ID: <20130521052552.GT4017@adacore.com> (raw)
In-Reply-To: <519A3DCC.1020805@redhat.com>

> IMO, having CONTRIBUTE in the source tree is a bit questionable.
> E.g., a user might write a patch against 7.5, and send it to the list,
> using the guidelines from 7.5's CONTRIBUTE file.  But, that file might
> well be outdated.  The guidelines that really matter are the one's gdb
> developers follow at present, which may already be different from
> the one's in 7.5's CONTRIBUTE.  I'd vote for migrating parts of the text
> from CONTRIBUTE under "Submitting Patches" and "Supplemental information
> for GDB" to the wiki.  But we can leave CONTRIBUTE alone until the
> documents actually diverge.

Transitioning the info from CONTRIBUTE to point to the wiki would
be OK for me.

> I don't think we need to be super strict about these tags.
> [PATCH]/[patch]/nothing is the same to me, as is
> [RFC PATCH] vs [RFC][PATCH].  But I do think it's good to have
> simple guidelines, mostly for people who are newcomers to the community.

Agreed.

Glad to see you put the patch description in the commit log, BTW!
I started doing that a while ago too, internally first, really liking
it, and then externally as well.

-- 
Joel


  reply	other threads:[~2013-05-21  5:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 16:37 Pedro Alves
2013-05-20 10:06 ` Joel Brobecker
2013-05-20 15:14   ` Pedro Alves
2013-05-21  5:26     ` Joel Brobecker [this message]
2013-05-21 17:55       ` Pedro Alves
2013-05-22  6:29         ` Joel Brobecker
2013-05-22 10:12           ` Pedro Alves
2013-05-22 10:23             ` Joel Brobecker
2013-05-22 10:38               ` Pedro Alves
2013-05-22 10:50                 ` Joel Brobecker
2013-05-22 14:56         ` Eli Zaretskii
2013-05-20 10:22 ` Hui Zhu
2013-05-20 14:44   ` Pedro Alves
2013-05-20 17:02     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130521052552.GT4017@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox