From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Hui Zhu <teawater@gmail.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: contribution checklist in the wiki
Date: Mon, 20 May 2013 17:02:00 -0000 [thread overview]
Message-ID: <CADPb22Qrug5Lgia2GpWKOydAmRnyqwQ=VdMuqOGDczBoPn0c=Q@mail.gmail.com> (raw)
In-Reply-To: <519A36DA.3060009@redhat.com>
On Mon, May 20, 2013 at 7:44 AM, Pedro Alves <palves@redhat.com> wrote:
>> I have a question about format of changelog:
>> 2013-12-12 John Doe <johndoe@some.email.address>
>>
>> PR gdb/9999
>>
>> * breakpoint.c (handle_some_event): Remove reference to<line
>> wrap at or before column 79>
>>
>> If I remember is right, some people told me that there should not have
>> a empty line after "PR xxx".
>> And I checked the changelog, some of them have empty line and others don't have.
>>
>> So does it need a empty line after "PR xxx"?
>>
>
> Thanks for raising this. Doug expressed a preference for not having
> the empty line too off-list. I've now removed it from the wiki.
>
> I've been adding it, as to me it visually indicated the different
> areas - the "why/PR" area vs the "what" area. Skimming through the
> entries, it seems I was practically alone though. :-) I'll
> stop adding it from here on.
[for reference sake,]
For me when skimming a blank line means an unrelated patch.
[There's no requirement that each separate patch be preceded by a
name/timestamp line,
and emacs knows this.]
It's easy enough to pick out a new patch set starting with some
sentence or "PR 123"
instead of "* filename ...".
prev parent reply other threads:[~2013-05-20 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 16:37 Pedro Alves
2013-05-20 10:06 ` Joel Brobecker
2013-05-20 15:14 ` Pedro Alves
2013-05-21 5:26 ` Joel Brobecker
2013-05-21 17:55 ` Pedro Alves
2013-05-22 6:29 ` Joel Brobecker
2013-05-22 10:12 ` Pedro Alves
2013-05-22 10:23 ` Joel Brobecker
2013-05-22 10:38 ` Pedro Alves
2013-05-22 10:50 ` Joel Brobecker
2013-05-22 14:56 ` Eli Zaretskii
2013-05-20 10:22 ` Hui Zhu
2013-05-20 14:44 ` Pedro Alves
2013-05-20 17:02 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Qrug5Lgia2GpWKOydAmRnyqwQ=VdMuqOGDczBoPn0c=Q@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox