From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26942 invoked by alias); 20 May 2013 17:02:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26933 invoked by uid 89); 20 May 2013 17:02:34 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-vb0-f48.google.com (HELO mail-vb0-f48.google.com) (209.85.212.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 20 May 2013 17:02:33 +0000 Received: by mail-vb0-f48.google.com with SMTP id q16so3911840vbe.21 for ; Mon, 20 May 2013 10:02:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=vvgvWs2oT5we7ArGpaHwf0T1A+s1USk5+Om7JZ6QCf0=; b=jQogpjSlA0bf2uAuuV5npAoN59SX2jyb6QoAXwCp9LwwPrVz1c1TmSSIm+nJPIBb6G PQmtyGLajSr7CfBefwFuO6iPpnNtp00gVRFNJtvZ2VgXcRoDFrbDVi9+tfaAB6kF2q/Y qeWiwLtHEWZeKnjuj2znbA52+M7UT77JyRihL0AfjMc8gHDVpl5GqWxGqspfqGNMtDHF kohPpkMjvyeBOiu0IeJNrfvkxZ/gykTIf8TDciOZ9cyaDeqq/9ZiTaAxjmRaUFp+rZlx z3p9QtQk3cSIUdZ+gcoGS71ljpsMU9AYM+3X9QsURzERmP3eYuhqqdgn4k+TepMxfOTL qfgA== MIME-Version: 1.0 X-Received: by 10.58.200.131 with SMTP id js3mr34510319vec.33.1369069351716; Mon, 20 May 2013 10:02:31 -0700 (PDT) Received: by 10.220.232.73 with HTTP; Mon, 20 May 2013 10:02:31 -0700 (PDT) In-Reply-To: <519A36DA.3060009@redhat.com> References: <51965CE3.4020805@redhat.com> <519A36DA.3060009@redhat.com> Date: Mon, 20 May 2013 17:02:00 -0000 Message-ID: Subject: Re: contribution checklist in the wiki From: Doug Evans To: Pedro Alves Cc: Hui Zhu , GDB Patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQkrUPfev2TQpgOqofB0wXH1MeAaOtAI0+HV4Uz6s1FCAi3DlsSIEMEJ0wKR25LzBFsi1xvkq6nKEijg0hXiBX1oDTf3t+HKonhy4m8nRAMBQcmNXK6SoBxpalEfspQwa16UF7ezF8KxKdnAEoZbmFZKbEq2d6QLWS0CliGGKHIRoPVuGcj5eTmgoKMA0Y79KqlCon5RqG+2qlzr6yR9jyMV3VQxzw== X-SW-Source: 2013-05/txt/msg00734.txt.bz2 On Mon, May 20, 2013 at 7:44 AM, Pedro Alves wrote: >> I have a question about format of changelog: >> 2013-12-12 John Doe >> >> PR gdb/9999 >> >> * breakpoint.c (handle_some_event): Remove reference to> wrap at or before column 79> >> >> If I remember is right, some people told me that there should not have >> a empty line after "PR xxx". >> And I checked the changelog, some of them have empty line and others don't have. >> >> So does it need a empty line after "PR xxx"? >> > > Thanks for raising this. Doug expressed a preference for not having > the empty line too off-list. I've now removed it from the wiki. > > I've been adding it, as to me it visually indicated the different > areas - the "why/PR" area vs the "what" area. Skimming through the > entries, it seems I was practically alone though. :-) I'll > stop adding it from here on. [for reference sake,] For me when skimming a blank line means an unrelated patch. [There's no requirement that each separate patch be preceded by a name/timestamp line, and emacs knows this.] It's easy enough to pick out a new patch set starting with some sentence or "PR 123" instead of "* filename ...".