From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10725 invoked by alias); 20 May 2013 10:22:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10714 invoked by uid 89); 20 May 2013 10:22:31 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-oa0-f41.google.com (HELO mail-oa0-f41.google.com) (209.85.219.41) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 20 May 2013 10:22:30 +0000 Received: by mail-oa0-f41.google.com with SMTP id n9so7555344oag.14 for ; Mon, 20 May 2013 03:22:29 -0700 (PDT) X-Received: by 10.182.108.132 with SMTP id hk4mr13705077obb.14.1369045349063; Mon, 20 May 2013 03:22:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.11.135 with HTTP; Mon, 20 May 2013 03:21:48 -0700 (PDT) In-Reply-To: <51965CE3.4020805@redhat.com> References: <51965CE3.4020805@redhat.com> From: Hui Zhu Date: Mon, 20 May 2013 10:22:00 -0000 Message-ID: Subject: Re: contribution checklist in the wiki To: Pedro Alves Cc: GDB Patches Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-05/txt/msg00723.txt.bz2 Hi Pedro, Thanks for you works. I have a question about format of changelog: 2013-12-12 John Doe PR gdb/9999 * breakpoint.c (handle_some_event): Remove reference to If I remember is right, some people told me that there should not have a empty line after "PR xxx". And I checked the changelog, some of them have empty line and others don't have. So does it need a empty line after "PR xxx"? And I have another question is about [RFC]. Where should it be sent to, gdb or gdb-patches? Best, Hui On Sat, May 18, 2013 at 12:37 AM, Pedro Alves wrote: > Guys, > > I've created a new page in the wiki: > > http://sourceware.org/gdb/wiki/ContributionChecklist > > This was heavily borrowed from glibc's own contribution checklist. > (I asked them if they were okay before doing it.) > > At present, some of the info there duplicates what gdb/CONTRIBUTE > says (but in different wording). I expect it to grow some, and I'd > rather keep it dynamic, without formal review/checking steps, which > IMO for this sort of think is a too heavy process. > I tailored the original text to make it fitter for gdb, but it's > possible/likely there are things that need more editing to make > it even fitter. > > I've been noticing that I often find myself pointing at the same > little mistakes over different submissions. E.g., pointing at > need to mention changes in NEWS. As I notice these patterns, I'll > add them to the wiki. I invite others to do the same. > > Thanks, > -- > Pedro Alves