Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Hui Zhu <hui_zhu@mentor.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base
Date: Tue, 04 Dec 2012 03:03:00 -0000	[thread overview]
Message-ID: <CANFwon0fr_Z4Mxk38+uNawHu9U+eJuvAF6aw7Y=-ankx_jD3Og@mail.gmail.com> (raw)
In-Reply-To: <87txs3vtmh.fsf@fleche.redhat.com>

On Tue, Dec 4, 2012 at 3:11 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> What about I change it to "frame address is not available." because in
> Hui> get_frame_block:
> Hui>   if (!get_frame_address_in_block_if_available (frame, &pc))
> Hui>     return NULL;
>
> Seems reasonable to me.
> This is ok.
>
> Tom

Should I commit this patch?

Thanks,
Hui


  reply	other threads:[~2012-12-04  3:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  1:45 Hui Zhu
2012-11-29 19:15 ` Tom Tromey
2012-12-01 16:34   ` Hui Zhu
2012-12-03 19:11     ` Tom Tromey
2012-12-04  3:03       ` Hui Zhu [this message]
2012-12-05 16:27         ` Tom Tromey
2012-12-06  1:17           ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANFwon0fr_Z4Mxk38+uNawHu9U+eJuvAF6aw7Y=-ankx_jD3Og@mail.gmail.com' \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox