From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base
Date: Thu, 29 Nov 2012 19:15:00 -0000 [thread overview]
Message-ID: <87k3t45ihq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50AC322D.2030209@mentor.com> (Hui Zhu's message of "Wed, 21 Nov 2012 09:45:17 +0800")
>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
Hui> 2012-11-20 Hui Zhu <hui_zhu@mentor.com>
Hui> * dwarf2loc.c (dwarf_expr_frame_base): Add check for the return
Hui> value of get_frame_block.
I think this is reasonable even without the rest of your patches.
One nit:
Hui> + if (bl == NULL)
Hui> + error (_("No symbol table info available.\n"));
I don't think this is a very clear error message.
I'm not sure what else to suggest though.
Also, no \n at the end of the error message.
Tom
next prev parent reply other threads:[~2012-11-29 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 1:45 Hui Zhu
2012-11-29 19:15 ` Tom Tromey [this message]
2012-12-01 16:34 ` Hui Zhu
2012-12-03 19:11 ` Tom Tromey
2012-12-04 3:03 ` Hui Zhu
2012-12-05 16:27 ` Tom Tromey
2012-12-06 1:17 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3t45ihq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox