From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96450-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29520 invoked by alias); 29 Nov 2012 19:15:34 -0000
Received: (qmail 29510 invoked by uid 22791); 29 Nov 2012 19:15:32 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 19:14:45 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qATJEhHT015170	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 29 Nov 2012 14:14:43 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qATJEfQ1012413	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 29 Nov 2012 14:14:42 -0500
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base
References: <50AC322D.2030209@mentor.com>
Date: Thu, 29 Nov 2012 19:15:00 -0000
In-Reply-To: <50AC322D.2030209@mentor.com> (Hui Zhu's message of "Wed, 21 Nov	2012 09:45:17 +0800")
Message-ID: <87k3t45ihq.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00888.txt.bz2

>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:

Hui> 2012-11-20  Hui Zhu  <hui_zhu@mentor.com>
Hui> 	* dwarf2loc.c (dwarf_expr_frame_base): Add check for the return
Hui> 	value of get_frame_block.

I think this is reasonable even without the rest of your patches.

One nit:

Hui> +  if (bl == NULL)
Hui> +    error (_("No symbol table info available.\n"));
 
I don't think this is a very clear error message.
I'm not sure what else to suggest though.

Also, no \n at the end of the error message.

Tom