Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <hui_zhu@mentor.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base
Date: Wed, 21 Nov 2012 01:45:00 -0000	[thread overview]
Message-ID: <50AC322D.2030209@mentor.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

After I add prev patch to GDB, the GDB got crash when a trace frame didn't include all the variables that it should include.
I think this issue should be handle because the trace frame didn't include all the variables will be always happen (What I use is GDB and gdbserver).
So I post this patch to handle it.

Thanks,
Hui

2012-11-20  Hui Zhu  <hui_zhu@mentor.com>

	* dwarf2loc.c (dwarf_expr_frame_base): Add check for the return
	value of get_frame_block.

[-- Attachment #2: check-get_frame_block-return.txt --]
[-- Type: text/plain, Size: 801 bytes --]

--- a/dwarf2loc.c
+++ b/dwarf2loc.c
@@ -332,11 +332,15 @@ dwarf_expr_frame_base (void *baton, cons
      this_base method.  */
   struct symbol *framefunc;
   struct dwarf_expr_baton *debaton = (struct dwarf_expr_baton *) baton;
+  struct block *bl = get_frame_block (debaton->frame, NULL);
+
+  if (bl == NULL)
+    error (_("No symbol table info available.\n"));
 
   /* Use block_linkage_function, which returns a real (not inlined)
      function, instead of get_frame_function, which may return an
      inlined function.  */
-  framefunc = block_linkage_function (get_frame_block (debaton->frame, NULL));
+  framefunc = block_linkage_function (bl);
 
   /* If we found a frame-relative symbol then it was certainly within
      some function associated with a frame. If we can't find the frame,

             reply	other threads:[~2012-11-21  1:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  1:45 Hui Zhu [this message]
2012-11-29 19:15 ` Tom Tromey
2012-12-01 16:34   ` Hui Zhu
2012-12-03 19:11     ` Tom Tromey
2012-12-04  3:03       ` Hui Zhu
2012-12-05 16:27         ` Tom Tromey
2012-12-06  1:17           ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AC322D.2030209@mentor.com \
    --to=hui_zhu@mentor.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox