From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96573-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14953 invoked by alias); 4 Dec 2012 03:03:07 -0000
Received: (qmail 14913 invoked by uid 22791); 4 Dec 2012 03:03:06 -0000
X-SWARE-Spam-Status: No, hits=-4.7 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Dec 2012 03:03:01 +0000
Received: by mail-bk0-f41.google.com with SMTP id jg9so1472973bkc.0        for <gdb-patches@sourceware.org>; Mon, 03 Dec 2012 19:02:59 -0800 (PST)
Received: by 10.204.156.11 with SMTP id u11mr3625142bkw.106.1354590179495; Mon, 03 Dec 2012 19:02:59 -0800 (PST)
MIME-Version: 1.0
Received: by 10.205.32.12 with HTTP; Mon, 3 Dec 2012 19:02:19 -0800 (PST)
In-Reply-To: <87txs3vtmh.fsf@fleche.redhat.com>
References: <50AC322D.2030209@mentor.com> <87k3t45ihq.fsf@fleche.redhat.com> <CANFwon2PbHAyE3skm5Ojz252W-YefTE0+37PJOK=fS7ds5WoVg@mail.gmail.com> <87txs3vtmh.fsf@fleche.redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Tue, 04 Dec 2012 03:03:00 -0000
Message-ID: <CANFwon0fr_Z4Mxk38+uNawHu9U+eJuvAF6aw7Y=-ankx_jD3Og@mail.gmail.com>
Subject: Re: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base
To: Tom Tromey <tromey@redhat.com>
Cc: Hui Zhu <hui_zhu@mentor.com>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00046.txt.bz2

On Tue, Dec 4, 2012 at 3:11 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> What about I change it to "frame address is not available." because in
> Hui> get_frame_block:
> Hui>   if (!get_frame_address_in_block_if_available (frame, &pc))
> Hui>     return NULL;
>
> Seems reasonable to me.
> This is ok.
>
> Tom

Should I commit this patch?

Thanks,
Hui