From: Mike Frysinger <vapier@gentoo.org>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] bfin: swapped args in bfin_extract_return_value?
Date: Wed, 20 Jul 2011 16:05:00 -0000 [thread overview]
Message-ID: <CAJaTeTp_9Aap0DRWiUjq=hcUdH5F0feGUKfSt=xDb8jqbwhHCQ@mail.gmail.com> (raw)
In-Reply-To: <CACTLOFpa7MrLx-1UTx08qX2Akdm=Ssb+tHHN0GjdFp+U6r9G-A@mail.gmail.com>
On Tue, Jul 19, 2011 at 22:12, Matt Rice wrote:
> I don't really know this code, so this patch might be wrong,
> and don't have a setup to test it.
>
> but from the types, and the variable names, it smells of arguments
> that have been swapped.
the Blackfin gdb port is currently being maintained against gdb-6.6
which didnt have an endian argument. when forward porting to
pre-gdb-7.3, the func now took an endian arg, so one was just thrown
in. when the func was updated in mainline gdb, rather than add the
new arg to the end, it was inserted, so i guess the update review
didnt go as well as hopped.
in my local version (which contains FDPIC support), it seems like all
calls to store_unsigned_integer() in bfin-tdep.c have the last two
args swapped. so i imagine it was an upgrade thinko.
-mike
next prev parent reply other threads:[~2011-07-20 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 6:10 Matt Rice
2011-07-20 14:15 ` Tom Tromey
2011-07-20 16:03 ` Yao Qi
2011-07-20 16:27 ` Mike Frysinger
2011-07-20 16:05 ` Mike Frysinger [this message]
2011-07-20 17:04 ` Matt Rice
2011-07-20 17:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJaTeTp_9Aap0DRWiUjq=hcUdH5F0feGUKfSt=xDb8jqbwhHCQ@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox