From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20148 invoked by alias); 20 Jul 2011 16:03:45 -0000 Received: (qmail 20133 invoked by uid 22791); 20 Jul 2011 16:03:43 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 16:03:29 +0000 Received: by iyb14 with SMTP id 14so392006iyb.0 for ; Wed, 20 Jul 2011 09:03:29 -0700 (PDT) Received: by 10.231.47.2 with SMTP id l2mr8253367ibf.174.1311177809113; Wed, 20 Jul 2011 09:03:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.217.71 with HTTP; Wed, 20 Jul 2011 09:03:09 -0700 (PDT) In-Reply-To: References: From: Mike Frysinger Date: Wed, 20 Jul 2011 16:05:00 -0000 Message-ID: Subject: Re: [patch] bfin: swapped args in bfin_extract_return_value? To: Matt Rice Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00542.txt.bz2 On Tue, Jul 19, 2011 at 22:12, Matt Rice wrote: > I don't really know this code, so this patch might be wrong, > and don't have a setup to test it. > > but from the types, and the variable names, it smells of arguments > that have been swapped. the Blackfin gdb port is currently being maintained against gdb-6.6 which didnt have an endian argument. when forward porting to pre-gdb-7.3, the func now took an endian arg, so one was just thrown in. when the func was updated in mainline gdb, rather than add the new arg to the end, it was inserted, so i guess the update review didnt go as well as hopped. in my local version (which contains FDPIC support), it seems like all calls to store_unsigned_integer() in bfin-tdep.c have the last two args swapped. so i imagine it was an upgrade thinko. -mike