From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Matt Rice <ratmice@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [patch] bfin: swapped args in bfin_extract_return_value?
Date: Wed, 20 Jul 2011 16:03:00 -0000 [thread overview]
Message-ID: <4E26F58C.8070306@codesourcery.com> (raw)
In-Reply-To: <m3fwm112a2.fsf@fleche.redhat.com>
On 07/20/2011 09:59 PM, Tom Tromey wrote:
> I think this change is good, but I don't understand why this function
> even calls store_unsigned_integer. I thought
> regcache_cooked_read_unsigned did that for you.
regcache_cooked_read_unsigned and store_unsigned_integer can be replaced
by regcache_cooked_read, IIUC. However, in the last iteration of loop,
the size of data might not be 4, so we may have to use
regcache_cooked_read_part and consider different data layout related to
endianess. Looks like current approach doesn't have to worry about this
problem.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-07-20 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 6:10 Matt Rice
2011-07-20 14:15 ` Tom Tromey
2011-07-20 16:03 ` Yao Qi [this message]
2011-07-20 16:27 ` Mike Frysinger
2011-07-20 16:05 ` Mike Frysinger
2011-07-20 17:04 ` Matt Rice
2011-07-20 17:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E26F58C.8070306@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox