From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Matt Rice <ratmice@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [patch] bfin: swapped args in bfin_extract_return_value?
Date: Wed, 20 Jul 2011 16:27:00 -0000 [thread overview]
Message-ID: <CAJaTeTqX1EYXHc409yh=X7cLgH=pmBeA49didb5Un+YqHDQgBw@mail.gmail.com> (raw)
In-Reply-To: <m3fwm112a2.fsf@fleche.redhat.com>
On Wed, Jul 20, 2011 at 09:59, Tom Tromey wrote:
>>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:
>
> Matt> 2011-07-11 Matt Rice <ratmice@gmail.com>
> Matt> * bfin-tdep.c (bfin_extract_return_value): Fix swapped
> Matt> arguments to store_unsigned_integer.
>
> I think this change is good, but I don't understand why this function
> even calls store_unsigned_integer. I thought
> regcache_cooked_read_unsigned did that for you.
most likely because regcache_cooked_read() doesnt exist in gdb-6.6
(which is where the Blackfin port originated). when moving from
something like 6.6 to 7.3, it's nigh impossible to pick out all the
idioms that have been obsoleted by new helper functions unless you're
very familiar with the gdb code base. which i am not :).
i can test your proposal and post a follow up patch if it pans out.
-mike
next prev parent reply other threads:[~2011-07-20 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 6:10 Matt Rice
2011-07-20 14:15 ` Tom Tromey
2011-07-20 16:03 ` Yao Qi
2011-07-20 16:27 ` Mike Frysinger [this message]
2011-07-20 16:05 ` Mike Frysinger
2011-07-20 17:04 ` Matt Rice
2011-07-20 17:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJaTeTqX1EYXHc409yh=X7cLgH=pmBeA49didb5Un+YqHDQgBw@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox