From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Remove 'read' call from dwz_file::read_string
Date: Mon, 24 Mar 2025 15:25:12 +0100 [thread overview]
Message-ID: <CAJVr-EMDS_Rcwz+T2Z=PGzkDy8G+ZQcTwoLUdQ4uc_0=53NOSQ@mail.gmail.com> (raw)
In-Reply-To: <20250323-dwz-dwarf-5-v2-v1-1-3c0775ca5514@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Sun, Mar 23, 2025 at 8:21 PM Tom Tromey <tom@tromey.com> wrote:
> dwz_file::read_string calls 'read' on the section, but this isn't
> needed as the sections have all been pre-read.
>
> This patch makes this change, and refactors dwz_file a bit to make
> this more obvious -- by making it clear that only the "static
> constructor" can create a dwz_file.
> ---
>
>
Hi Tom,
I tested this on aarch64, Fedora 40 and this change causes no regressions.
Tested-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
[-- Attachment #2: Type: text/html, Size: 1020 bytes --]
next prev parent reply other threads:[~2025-03-24 16:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 19:19 [PATCH 0/3] Support DWARF 5 .debug_sup section Tom Tromey
2025-03-23 19:20 ` [PATCH 1/3] Remove 'read' call from dwz_file::read_string Tom Tromey
2025-03-24 14:25 ` Alexandra Petlanova Hajkova [this message]
2025-03-24 20:30 ` Simon Marchi
2025-03-24 20:52 ` Tom Tromey
2025-03-23 19:20 ` [PATCH 2/3] Handle DWARF 5 separate debug sections Tom Tromey
2025-03-24 15:45 ` Alexandra Petlanova Hajkova
2025-03-24 17:16 ` Tom Tromey
2025-04-03 14:39 ` Tom Tromey
2025-04-22 14:55 ` Tom Tromey
2025-04-22 15:10 ` Simon Marchi
2025-04-28 11:35 ` Tom de Vries
2025-03-24 20:52 ` Simon Marchi
2025-03-25 13:37 ` Tom Tromey
2025-03-23 19:20 ` [PATCH 3/3] Add "-5" flag to cc-with-tweaks Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJVr-EMDS_Rcwz+T2Z=PGzkDy8G+ZQcTwoLUdQ4uc_0=53NOSQ@mail.gmail.com' \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox