From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Remove 'read' call from dwz_file::read_string
Date: Mon, 24 Mar 2025 14:52:57 -0600 [thread overview]
Message-ID: <87ecym6thy.fsf@tromey.com> (raw)
In-Reply-To: <b3b1fdf5-8ba5-4c9a-9ead-1779551a60db@simark.ca> (Simon Marchi's message of "Mon, 24 Mar 2025 16:30:56 -0400")
>> - auto result = std::make_unique<dwz_file> (std::move (dwz_bfd));
>> + dwz_file_up result (new dwz_file (std::move (dwz_bfd)));
Simon> Why this change?
make_unique can't access a private constructor.
It's a bit of a wart on C++ IMO.
Tom
next prev parent reply other threads:[~2025-03-24 20:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 19:19 [PATCH 0/3] Support DWARF 5 .debug_sup section Tom Tromey
2025-03-23 19:20 ` [PATCH 1/3] Remove 'read' call from dwz_file::read_string Tom Tromey
2025-03-24 14:25 ` Alexandra Petlanova Hajkova
2025-03-24 20:30 ` Simon Marchi
2025-03-24 20:52 ` Tom Tromey [this message]
2025-03-23 19:20 ` [PATCH 2/3] Handle DWARF 5 separate debug sections Tom Tromey
2025-03-24 15:45 ` Alexandra Petlanova Hajkova
2025-03-24 17:16 ` Tom Tromey
2025-04-03 14:39 ` Tom Tromey
2025-04-22 14:55 ` Tom Tromey
2025-04-22 15:10 ` Simon Marchi
2025-04-28 11:35 ` Tom de Vries
2025-03-24 20:52 ` Simon Marchi
2025-03-25 13:37 ` Tom Tromey
2025-03-23 19:20 ` [PATCH 3/3] Add "-5" flag to cc-with-tweaks Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecym6thy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox