From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6FD6K1XG4WdDvxkAWB0awg (envelope-from ) for ; Mon, 24 Mar 2025 16:53:41 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=v2xvYbvn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B00801E10E; Mon, 24 Mar 2025 16:53:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 69B001E0C0 for ; Mon, 24 Mar 2025 16:53:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E37213857C5D for ; Mon, 24 Mar 2025 20:53:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E37213857C5D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=v2xvYbvn Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 3D53B3858D29 for ; Mon, 24 Mar 2025 20:53:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D53B3858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D53B3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742849582; cv=none; b=aSNDFk2zFAi5qd9KqWBEcxdKkQ9Rv+r7hy0AJ+JY3K1G/vzK3uirH97domUg3I0ekvVuspHmSccea10KaudW9miJcDtnqIGfn3D1nBnCQGldUXFSg76Tuhr+Xt0f13ybMu4NS+UmhjfbxVIK84I1BJeOmk3d1Skm4eEOiMXp/YU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742849582; c=relaxed/simple; bh=ZXFYfumS+GXUN/zlXrFSOmQfDKdZRwnCGWCFPTAV7Lg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NQY72Kh8X6pbxMUEuJuk52+VKgFI/uFIL+T1SDp61KdQVXzWssu/55pbaykfpCj0RNVWWVcnL/wWGRzNn9MpH0sWRN9d5VFcRnpwQdlAqVrTrENEV/1lr0nqpLLKZbVx1nILBhH48Ywvnr+oL738mvup7jzNcTWwMnF7e4/lwng= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D53B3858D29 Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id wlkptejJpXshwwon7tPfUQ; Mon, 24 Mar 2025 20:53:01 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id won6twkLAiHrewon6t2qOx; Mon, 24 Mar 2025 20:53:00 +0000 X-Authority-Analysis: v=2.4 cv=H43dwfYi c=1 sm=1 tr=0 ts=67e1c62c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=ue1G_uC6oO3pRgVn-BwA:9 a=zZCYzV9kfG8A:10 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fsawXwS0ZDGVUKG0Fkv96G1/Xd5OfrkyG59GzcLwj4E=; b=v2xvYbvn0JQCjI/wZ2yUEMNVOK DKNPtEFTEEDHllZaoGzvM3Q1fsdMEa/WVKQcKLLDztLqtIWJZJTYBjlZIqq5MSt39Ug32qS2W2E3q 1VgUhfOlunHzsLQ2PCysj/hmY; Received: from 97-122-123-18.hlrn.qwest.net ([97.122.123.18]:54754 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1twon5-00000001YQI-2M42; Mon, 24 Mar 2025 14:52:59 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Remove 'read' call from dwz_file::read_string In-Reply-To: (Simon Marchi's message of "Mon, 24 Mar 2025 16:30:56 -0400") References: <20250323-dwz-dwarf-5-v2-v1-0-3c0775ca5514@tromey.com> <20250323-dwz-dwarf-5-v2-v1-1-3c0775ca5514@tromey.com> X-Attribution: Tom Date: Mon, 24 Mar 2025 14:52:57 -0600 Message-ID: <87ecym6thy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.123.18 X-Source-L: No X-Exim-ID: 1twon5-00000001YQI-2M42 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-123-18.hlrn.qwest.net (prentzel) [97.122.123.18]:54754 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKIDiuzQC0JDo9TeNXME66VMby3n7JGJqWAnhTjpk9A+ZOwHWmo7XCQPVGqbMtUSva24wfFY9Kt7sbT528oSVaISbjPgl1NtIbk8OpSFcuCgDKlrFlwW DiyJDFOk4YYhjpA0wEBFzKQLxyGdhAb6Z3oKz7KiMVE2yDFnuP4AWr47ippf8hNoCPE/3roZGRfw7+r5jPl/PsJ8q3WN9Aomiyo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> - auto result = std::make_unique (std::move (dwz_bfd)); >> + dwz_file_up result (new dwz_file (std::move (dwz_bfd))); Simon> Why this change? make_unique can't access a private constructor. It's a bit of a wart on C++ IMO. Tom