From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Handle DWARF 5 separate debug sections
Date: Tue, 25 Mar 2025 07:37:22 -0600 [thread overview]
Message-ID: <87jz8dgrjh.fsf@tromey.com> (raw)
In-Reply-To: <4301b473-7127-4c95-9f7a-d938f1bdb868@simark.ca> (Simon Marchi's message of "Mon, 24 Mar 2025 16:52:59 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> + if (*buildid_len != 0)
>> + buildid->reset ((bfd_byte *) xmemdup (contents, *buildid_len,
>> + *buildid_len));
Simon> Could we return a view inside the section, instead of copying the bytes?
Simon> It seems like we are just copying the bytes as is.
In this code, the section isn't mapped but instead just read in and then
discarded. That's done because it's only needed for a moment while
reading -- once the file is found the .debug_sup contents aren't needed.
Tom
next prev parent reply other threads:[~2025-03-25 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 19:19 [PATCH 0/3] Support DWARF 5 .debug_sup section Tom Tromey
2025-03-23 19:20 ` [PATCH 1/3] Remove 'read' call from dwz_file::read_string Tom Tromey
2025-03-24 14:25 ` Alexandra Petlanova Hajkova
2025-03-24 20:30 ` Simon Marchi
2025-03-24 20:52 ` Tom Tromey
2025-03-23 19:20 ` [PATCH 2/3] Handle DWARF 5 separate debug sections Tom Tromey
2025-03-24 15:45 ` Alexandra Petlanova Hajkova
2025-03-24 17:16 ` Tom Tromey
2025-04-03 14:39 ` Tom Tromey
2025-04-22 14:55 ` Tom Tromey
2025-04-22 15:10 ` Simon Marchi
2025-04-28 11:35 ` Tom de Vries
2025-03-24 20:52 ` Simon Marchi
2025-03-25 13:37 ` Tom Tromey [this message]
2025-03-23 19:20 ` [PATCH 3/3] Add "-5" flag to cc-with-tweaks Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz8dgrjh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox