From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tWtJFEmK4Wf4kRkAWB0awg (envelope-from ) for ; Mon, 24 Mar 2025 12:37:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Eq6R9z3+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 438061E100; Mon, 24 Mar 2025 12:37:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C446C1E0C0 for ; Mon, 24 Mar 2025 12:37:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5ADEB3858CDA for ; Mon, 24 Mar 2025 16:37:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5ADEB3858CDA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Eq6R9z3+ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AA6693858D21 for ; Mon, 24 Mar 2025 14:25:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA6693858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA6693858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742826331; cv=none; b=RY0nyv/kKYE2LBxsa4gxEb5+dSSQrhSTttG21l9AbRNNVkAjlJTmRvuL9ByHmINQqa6V+8YKBJctkU9Gx3sH8hItbpibbs4YZTD5Mb3J7aR77GXCpHB34en17pgtZ26UF5qQ+b//S/MfDEI4dsCXWWOqu4lp8i0x64fjbhb76P8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742826331; c=relaxed/simple; bh=ecUddQxM5inUSWmbXt97rFYLlvFCFw8kNlh524WgUKI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Er5bk0kt+k5oB666aWnaeEivGa2wIUEEc5Zzu3MDlZX1UgOda18cSQLXmfS1SQZHQ/xltd5exaegFHFU5senuKrAQAbvD1hnG47Dx8Dg3NC7xat+MPE9FsMngfFlOC69OeJ+6QmkTRFbiO9mnMXOXlhE4LxGgRTPiJ5bQMzJjHk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA6693858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742826326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ecUddQxM5inUSWmbXt97rFYLlvFCFw8kNlh524WgUKI=; b=Eq6R9z3+/e97fHTHmC1IdOckliInwzSyynEnkk5emMm9xlwUggDPXbLyPmNende0aUrlit TgjKi+dNXf/bZ4t6fQrZNu1GbQ3YX2ljNWD6+ii1LFMNOHHLSbsmjgEz72yoTAOX7ZiwI4 YgJtOduRQjx1Z8qp+wqkXKBKlnnC6G4= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-d3zOPjk8NeWEi2wNW00a3g-1; Mon, 24 Mar 2025 10:25:25 -0400 X-MC-Unique: d3zOPjk8NeWEi2wNW00a3g-1 X-Mimecast-MFC-AGG-ID: d3zOPjk8NeWEi2wNW00a3g_1742826324 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2ff4b130bb2so7393606a91.0 for ; Mon, 24 Mar 2025 07:25:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742826324; x=1743431124; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ecUddQxM5inUSWmbXt97rFYLlvFCFw8kNlh524WgUKI=; b=aekap95OJKmZBcEJXmtD9ElFjmvIYRgbyHKhR3m3Y/rjOGrhn6aQkjQqyHKmFeDrbR TJK+KT/+1u4dJTlpJbHhtQbUIHtDYoeyD7V+XTI3NegEkwcFMmaXhNF7v1n7PoyYhx+q IXrU4Q93D8aKYZOlccB4h+C3n0WYQTUwrbUrzipNNT5/6WhBIu/1mmHfmQAgElNJr0XV Nvyrs5QQ0vECc2F1xtA/B1yn4EWO1HKRVh5I8I6EEHAxjwDQARDPI4QDne8bGngndWA1 DysZQHrQv4TrQAUWKpQh6AFRRudqbtmJzAzjC1DeJH3eIziuQqYLYSYhNhA38NLsI+01 MC4g== X-Gm-Message-State: AOJu0YzLD4rS350/J613cIMufaF8z1GG7CClP6MPqXCslgHv7NTFe4bs mVpslQHCCzNGGvCYukiNmhzRIJ8tH3ckN79xZmD3R5BmSdwU6y8qljNw518zvZfJimgkRUjf3Fh hC94dh6PDhTrykJFwPUXQQ1/qamjYa7sx4Zuy9olrn4aNt8nB6GOUVaaF7Lc4z8/VLIPF48U4/G 6LdCryzBOlR5ssNCqQ5NgHgnx/tTmfoFNtH31GmytwPVIT X-Gm-Gg: ASbGncufBcIJHDbxejXUvGOLcBbR1CuUHVwixYviu65iptXvx0gHYqszch0JZ//iig1 Jwz45KigfmbDnX4GUduCS8IrVih35/BS25gg8sKjGjCaX4K2/zIrSejEmz3fmLROII8pLm4OhSt k= X-Received: by 2002:a17:90b:4d07:b0:2ff:62b7:dcc0 with SMTP id 98e67ed59e1d1-3030fe953f8mr20576443a91.15.1742826323500; Mon, 24 Mar 2025 07:25:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtS+03mMAXis9YESj5Ys+jaWzp56jPAVPzTSQwSgfeSK4SXtT9QBol3P2yOLurQEMqv1xJner9JpA+fJAbmZc= X-Received: by 2002:a17:90b:4d07:b0:2ff:62b7:dcc0 with SMTP id 98e67ed59e1d1-3030fe953f8mr20576391a91.15.1742826323055; Mon, 24 Mar 2025 07:25:23 -0700 (PDT) MIME-Version: 1.0 References: <20250323-dwz-dwarf-5-v2-v1-0-3c0775ca5514@tromey.com> <20250323-dwz-dwarf-5-v2-v1-1-3c0775ca5514@tromey.com> In-Reply-To: <20250323-dwz-dwarf-5-v2-v1-1-3c0775ca5514@tromey.com> From: Alexandra Petlanova Hajkova Date: Mon, 24 Mar 2025 15:25:12 +0100 X-Gm-Features: AQ5f1JraNKy2O1wllhbhop1aEwvgZG31ipdklWXLrIvyK-4ugRVPR5dCr68UpiI Message-ID: Subject: Re: [PATCH 1/3] Remove 'read' call from dwz_file::read_string To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7jPfB62ipRyY01OgUxGWtOex6xt8U44JFl2fcW3QUP8_1742826324 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000e428870631175f0c" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --000000000000e428870631175f0c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 23, 2025 at 8:21=E2=80=AFPM Tom Tromey wrote: > dwz_file::read_string calls 'read' on the section, but this isn't > needed as the sections have all been pre-read. > > This patch makes this change, and refactors dwz_file a bit to make > this more obvious -- by making it clear that only the "static > constructor" can create a dwz_file. > --- > > Hi Tom, I tested this on aarch64, Fedora 40 and this change causes no regressions. Tested-By: Alexandra Petlanova Hajkova --000000000000e428870631175f0c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Mar 23,= 2025 at 8:21=E2=80=AFPM Tom Tromey <t= om@tromey.com> wrote:
dwz_file::read_string calls 'read' on the section, but= this isn't
needed as the sections have all been pre-read.

This patch makes this change, and refactors dwz_file a bit to make
this more obvious -- by making it clear that only the "static
constructor" can create a dwz_file.
---


Hi Tom,

I tes= ted this on aarch64, Fedora 40 and this change causes no regressions.
=

Tested-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
=C2=A0
=
--000000000000e428870631175f0c--