From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 20/348] Fix -Wsahdow warnings
Date: Thu, 24 Nov 2011 03:19:00 -0000 [thread overview]
Message-ID: <CAHQ1cqGd9rN3gP6AHy=z=aKhnmqR84Y2bzpJm3_G_DV2OZobfw@mail.gmail.com> (raw)
In-Reply-To: <201111231639.pANGdd7R027802@glazunov.sibelius.xs4all.nl>
On Wed, Nov 23, 2011 at 11:39 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> From: Andrey Smirnov <andrew.smirnov@gmail.com>
>> Date: Tue, 22 Nov 2011 20:02:56 +0700
>>
>> From: Andrey Smirnov <andrew.smirnov@gmail.com>
>> Date: Tue, 22 Nov 2011 17:29:45 +0700
>>
>> * amd64-tdep.c (amd64_push_dummy_call): Fix -Wshadow
>> warnings.
>
> That's a stupid change. Please simply remove the 2nd tdep declaration
> in that function and leave the rest of the code as is.
>
That may very well be, but changing it that way allowed me, a person without
solid knowledge of the codebase, to be sure I didn't introduce any
side effects since changing it the way you propose would rewrite the
value of `tdep'. That was my reasoning for doing it. Was it
invalid?
Andrey Smirnov
P.S. I'll change it.
prev parent reply other threads:[~2011-11-24 3:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:03 Andrey Smirnov
2011-11-22 18:07 ` Tom Tromey
2011-11-28 15:17 ` [PATCH 020/238] [misc.] amd64-tdep.: -Wshadow fix Andrey Smirnov
2011-11-28 16:17 ` Mark Kettenis
2011-11-23 16:39 ` [PATCH 20/348] Fix -Wsahdow warnings Mark Kettenis
2011-11-23 16:56 ` Tom Tromey
2011-11-23 17:08 ` Mark Kettenis
2011-11-24 3:19 ` Andrey Smirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqGd9rN3gP6AHy=z=aKhnmqR84Y2bzpJm3_G_DV2OZobfw@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox