Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: andrew.smirnov@gmail.com
Cc: gdb-patches@sourceware.org, tromey@redhat.com
Subject: Re: [PATCH 020/238] [misc.] amd64-tdep.: -Wshadow fix
Date: Mon, 28 Nov 2011 16:17:00 -0000	[thread overview]
Message-ID: <201111281617.pASGH1K1021364@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1322493396-29592-1-git-send-email-andrew.smirnov@gmail.com>	(message from Andrey Smirnov on Mon, 28 Nov 2011 22:16:36 +0700)

> From: Andrey Smirnov <andrew.smirnov@gmail.com>
> Date: Mon, 28 Nov 2011 22:16:36 +0700
> 
> Cause:
>         It is a ALBW type of clash, the first declaration of the
>         variable is at the beginning of the function.
> 
> To ChangeLog:
> 	* amd64-tdep.c (amd64_push_dummy_call): Remove nested
>         definition of `tdep'(-Wshadow).

ok kettenis@

> ---
>  gdb/ChangeLog    |    5 +++++
>  gdb/amd64-tdep.c |    1 -
>  2 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 6dbac0d..6e1121d 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,10 @@
>  2011-11-22  Andrey Smirnov <andrew.smirnov@gmail.com>
>  
> +	* amd64-tdep.c (amd64_push_dummy_call): Fix -Wshadow
> +	warnings.
> +
> +2011-11-22  Andrey Smirnov <andrew.smirnov@gmail.com>
> +
>  	* amd64-tdep.c (amd64_get_unused_input_int_reg): Fix -Wshadow
>  	warnings.
>  
> diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
> index 29101a4..987f80d 100644
> --- a/gdb/amd64-tdep.c
> +++ b/gdb/amd64-tdep.c
> @@ -878,7 +878,6 @@ amd64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
>    /* Pass "hidden" argument".  */
>    if (struct_return)
>      {
> -      struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
>        /* The "hidden" argument is passed throught the first argument
>           register.  */
>        const int arg_regnum = tdep->call_dummy_integer_regs[0];
> -- 
> 1.7.5.4
> 
> 


  reply	other threads:[~2011-11-28 16:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 13:03 [PATCH 20/348] Fix -Wsahdow warnings Andrey Smirnov
2011-11-22 18:07 ` Tom Tromey
2011-11-28 15:17   ` [PATCH 020/238] [misc.] amd64-tdep.: -Wshadow fix Andrey Smirnov
2011-11-28 16:17     ` Mark Kettenis [this message]
2011-11-23 16:39 ` [PATCH 20/348] Fix -Wsahdow warnings Mark Kettenis
2011-11-23 16:56   ` Tom Tromey
2011-11-23 17:08     ` Mark Kettenis
2011-11-24  3:19   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111281617.pASGH1K1021364@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=andrew.smirnov@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox