From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2291 invoked by alias); 28 Nov 2011 16:17:29 -0000 Received: (qmail 2259 invoked by uid 22791); 28 Nov 2011 16:17:23 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Nov 2011 16:17:08 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id pASGH2L7018348; Mon, 28 Nov 2011 17:17:02 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id pASGH1K1021364; Mon, 28 Nov 2011 17:17:01 +0100 (CET) Date: Mon, 28 Nov 2011 16:17:00 -0000 Message-Id: <201111281617.pASGH1K1021364@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: andrew.smirnov@gmail.com CC: gdb-patches@sourceware.org, tromey@redhat.com In-reply-to: <1322493396-29592-1-git-send-email-andrew.smirnov@gmail.com> (message from Andrey Smirnov on Mon, 28 Nov 2011 22:16:36 +0700) Subject: Re: [PATCH 020/238] [misc.] amd64-tdep.: -Wshadow fix References: <1322493396-29592-1-git-send-email-andrew.smirnov@gmail.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00777.txt.bz2 > From: Andrey Smirnov > Date: Mon, 28 Nov 2011 22:16:36 +0700 > > Cause: > It is a ALBW type of clash, the first declaration of the > variable is at the beginning of the function. > > To ChangeLog: > * amd64-tdep.c (amd64_push_dummy_call): Remove nested > definition of `tdep'(-Wshadow). ok kettenis@ > --- > gdb/ChangeLog | 5 +++++ > gdb/amd64-tdep.c | 1 - > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 6dbac0d..6e1121d 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,10 @@ > 2011-11-22 Andrey Smirnov > > + * amd64-tdep.c (amd64_push_dummy_call): Fix -Wshadow > + warnings. > + > +2011-11-22 Andrey Smirnov > + > * amd64-tdep.c (amd64_get_unused_input_int_reg): Fix -Wshadow > warnings. > > diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c > index 29101a4..987f80d 100644 > --- a/gdb/amd64-tdep.c > +++ b/gdb/amd64-tdep.c > @@ -878,7 +878,6 @@ amd64_push_dummy_call (struct gdbarch *gdbarch, struct value *function, > /* Pass "hidden" argument". */ > if (struct_return) > { > - struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); > /* The "hidden" argument is passed throught the first argument > register. */ > const int arg_regnum = tdep->call_dummy_integer_regs[0]; > -- > 1.7.5.4 > >