From: Tom Tromey <tromey@redhat.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 20/348] Fix -Wsahdow warnings
Date: Tue, 22 Nov 2011 18:07:00 -0000 [thread overview]
Message-ID: <m3vcqc3uaz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87bos48g3j.fsf@gmail.com> (Andrey Smirnov's message of "Tue, 22 Nov 2011 20:02:56 +0700")
>>>>> "Andrey" == Andrey Smirnov <andrew.smirnov@gmail.com> writes:
Andrey> * amd64-tdep.c (amd64_push_dummy_call): Fix -Wshadow
Andrey> warnings.
Andrey> - struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
Andrey> /* The "hidden" argument is passed throught the first argument
Andrey> register. */
Andrey> - const int arg_regnum = tdep->call_dummy_integer_regs[0];
Andrey> +
Andrey> + const int arg_regnum =
Andrey> + gdbarch_tdep (gdbarch)->call_dummy_integer_regs[0];
Here you can just remove 'tdep' and use the outer one.
It has the same value.
That is, no change to arg_regnum's initialization is needed.
Tom
next prev parent reply other threads:[~2011-11-22 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:03 Andrey Smirnov
2011-11-22 18:07 ` Tom Tromey [this message]
2011-11-28 15:17 ` [PATCH 020/238] [misc.] amd64-tdep.: -Wshadow fix Andrey Smirnov
2011-11-28 16:17 ` Mark Kettenis
2011-11-23 16:39 ` [PATCH 20/348] Fix -Wsahdow warnings Mark Kettenis
2011-11-23 16:56 ` Tom Tromey
2011-11-23 17:08 ` Mark Kettenis
2011-11-24 3:19 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vcqc3uaz.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox