From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85492-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16411 invoked by alias); 24 Nov 2011 03:19:12 -0000
Received: (qmail 16403 invoked by uid 22791); 24 Nov 2011 03:19:12 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-gy0-f169.google.com (HELO mail-gy0-f169.google.com) (209.85.160.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Nov 2011 03:18:58 +0000
Received: by ghrr17 with SMTP id r17so2541852ghr.0        for <gdb-patches@sourceware.org>; Wed, 23 Nov 2011 19:18:58 -0800 (PST)
MIME-Version: 1.0
Received: by 10.50.194.229 with SMTP id hz5mr30772722igc.36.1322104737948; Wed, 23 Nov 2011 19:18:57 -0800 (PST)
Received: by 10.50.186.228 with HTTP; Wed, 23 Nov 2011 19:18:57 -0800 (PST)
In-Reply-To: <201111231639.pANGdd7R027802@glazunov.sibelius.xs4all.nl>
References: <87bos48g3j.fsf@gmail.com>	<201111231639.pANGdd7R027802@glazunov.sibelius.xs4all.nl>
Date: Thu, 24 Nov 2011 03:19:00 -0000
Message-ID: <CAHQ1cqGd9rN3gP6AHy=z=aKhnmqR84Y2bzpJm3_G_DV2OZobfw@mail.gmail.com>
Subject: Re: [PATCH 20/348] Fix -Wsahdow warnings
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00669.txt.bz2

On Wed, Nov 23, 2011 at 11:39 PM, Mark Kettenis <mark.kettenis@xs4all.nl> w=
rote:
>> From: Andrey Smirnov <andrew.smirnov@gmail.com>
>> Date: Tue, 22 Nov 2011 20:02:56 +0700
>>
>> From: Andrey Smirnov <andrew.smirnov@gmail.com>
>> Date: Tue, 22 Nov 2011 17:29:45 +0700
>>
>> * amd64-tdep.c (amd64_push_dummy_call): Fix -Wshadow
>> warnings.
>
> That's a stupid change. =A0Please simply remove the 2nd tdep declaration
> in that function and leave the rest of the code as is.
>

That may very well be, but changing it that way allowed me, a person without
solid knowledge of the codebase, to be sure I didn't introduce any
side effects since changing it the way you propose would rewrite the
value of `tdep'. That was my reasoning for doing it. Was it
invalid?

Andrey Smirnov

P.S. I'll change it.