From: Cary Coutant <ccoutant@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Add global/static and symbol kind indicator to .gdb_index
Date: Fri, 22 Jun 2012 21:20:00 -0000 [thread overview]
Message-ID: <CAHACq4qC2Oek_68_cNy2kJ-HkVnn6AwXWRceoG4aiU3E-oBmQg@mail.gmail.com> (raw)
In-Reply-To: <87y5nfdpq7.fsf@fleche.redhat.com>
> Doug> The global/static bit massively speeds up looking up things like
> Doug> "int" when debugging with lots of shared libraries (all having
> Doug> .gdb_index). PR 14125
>
> Tom> I don't think this patch is needed to achieve this. At least, the "int"
> Tom> case and other similar cases were fixed by:
>
> Doug pointed out on irc that I was mistaken here.
> The issue in his case is that, even though each individual index has a
> single entry for "int", there are still many indices, so gdb still does
> excessive CU expansion.
> I'm sorry for the error.
Is there still something I need to fix in gold in this regard? I think
gold will produce an index entry for "int" in every CU that mentions
it. If the right thing to do is to have only one CU, how do I decide
what kinds of names get this treatment? (For example, some arbitrary
type "struct foo" might actually be a different type, and you'd want
multiple index entries.)
-cary
next prev parent reply other threads:[~2012-06-22 21:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 7:49 Doug Evans
2012-06-19 14:01 ` Pedro Alves
2012-06-19 16:08 ` Eli Zaretskii
2012-06-19 19:41 ` Doug Evans
2012-06-22 19:45 ` Tom Tromey
2012-06-22 21:03 ` Tom Tromey
2012-06-22 21:20 ` Cary Coutant [this message]
2012-06-23 19:59 ` Doug Evans
2012-06-25 14:53 ` Tom Tromey
2012-06-25 15:06 ` Tom Tromey
2012-06-23 22:25 ` Doug Evans
2012-06-24 8:09 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHACq4qC2Oek_68_cNy2kJ-HkVnn6AwXWRceoG4aiU3E-oBmQg@mail.gmail.com \
--to=ccoutant@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox