Re: [RFA] Add global/static and symbol kind indicator to .gdb_index

[Doug Evans <dje@google.com>]

On Fri, Jun 22, 2012 at 2:02 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
>
> Doug> The global/static bit massively speeds up looking up things like
> Doug> "int" when debugging with lots of shared libraries (all having
> Doug> .gdb_index).  PR 14125
>
> Tom> I don't think this patch is needed to achieve this.  At least, the "int"
> Tom> case and other similar cases were fixed by:
>
> Doug pointed out on irc that I was mistaken here.
> The issue in his case is that, even though each individual index has a
> single entry for "int", there are still many indices, so gdb still does
> excessive CU expansion.
> I'm sorry for the error.
>
> Tom> I think it is ok.
>
> At least this part still seems correct ;-)
>
> Tom

Thanks.
Committed with this NEWS entry.


diff -u -p -r1.527 -r1.528
--- NEWS        6 Jun 2012 18:03:53 -0000       1.527
+++ NEWS        23 Jun 2012 22:23:46 -0000      1.528
@@ -112,6 +112,12 @@
   the ability to set breakpoints on inlined functions will be lost
   in symbol files with older .gdb_index sections.

+  The .gdb_index section has also been updated to record more information
+  about each symbol.  This speeds up the "info variables", "info functions"
+  and "info types" commands when used with programs having the .gdb_index
+  section, as well as speeding up debugging with shared libraries using
+  the .gdb_index section.
+
 * Ada support for GDB/MI Variable Objects has been added.

 * GDB can now support 'breakpoint always-inserted mode' in 'record'