Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org, ccoutant@google.com
Subject: Re: [RFA] Add global/static and symbol kind indicator to .gdb_index
Date: Fri, 22 Jun 2012 21:03:00 -0000	[thread overview]
Message-ID: <87y5nfdpq7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87txy3f7wr.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri,	22 Jun 2012 13:44:52 -0600")

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Doug> The global/static bit massively speeds up looking up things like
Doug> "int" when debugging with lots of shared libraries (all having
Doug> .gdb_index).  PR 14125

Tom> I don't think this patch is needed to achieve this.  At least, the "int"
Tom> case and other similar cases were fixed by:

Doug pointed out on irc that I was mistaken here.
The issue in his case is that, even though each individual index has a
single entry for "int", there are still many indices, so gdb still does
excessive CU expansion.
I'm sorry for the error.

Tom> I think it is ok.

At least this part still seems correct ;-)

Tom


  reply	other threads:[~2012-06-22 21:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19  7:49 Doug Evans
2012-06-19 14:01 ` Pedro Alves
2012-06-19 16:08 ` Eli Zaretskii
2012-06-19 19:41   ` Doug Evans
2012-06-22 19:45 ` Tom Tromey
2012-06-22 21:03   ` Tom Tromey [this message]
2012-06-22 21:20     ` Cary Coutant
2012-06-23 19:59       ` Doug Evans
2012-06-25 14:53         ` Tom Tromey
2012-06-25 15:06       ` Tom Tromey
2012-06-23 22:25     ` Doug Evans
2012-06-24  8:09   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5nfdpq7.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=ccoutant@google.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox