From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20811 invoked by alias); 22 Jun 2012 21:03:14 -0000 Received: (qmail 20803 invoked by uid 22791); 22 Jun 2012 21:03:13 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jun 2012 21:03:00 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5ML2vDm008635 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Jun 2012 17:02:58 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5ML2uMU001486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 22 Jun 2012 17:02:57 -0400 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org, ccoutant@google.com Subject: Re: [RFA] Add global/static and symbol kind indicator to .gdb_index References: <20120619074931.6F0B41E136F@ruffy2.mtv.corp.google.com> <87txy3f7wr.fsf@fleche.redhat.com> Date: Fri, 22 Jun 2012 21:03:00 -0000 In-Reply-To: <87txy3f7wr.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri, 22 Jun 2012 13:44:52 -0600") Message-ID: <87y5nfdpq7.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00739.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Doug> The global/static bit massively speeds up looking up things like Doug> "int" when debugging with lots of shared libraries (all having Doug> .gdb_index). PR 14125 Tom> I don't think this patch is needed to achieve this. At least, the "int" Tom> case and other similar cases were fixed by: Doug pointed out on irc that I was mistaken here. The issue in his case is that, even though each individual index has a single entry for "int", there are still many indices, so gdb still does excessive CU expansion. I'm sorry for the error. Tom> I think it is ok. At least this part still seems correct ;-) Tom