From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23546 invoked by alias); 23 Jun 2012 22:25:40 -0000 Received: (qmail 23521 invoked by uid 22791); 23 Jun 2012 22:25:38 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 Jun 2012 22:25:26 +0000 Received: by vcbfl10 with SMTP id fl10so1780125vcb.0 for ; Sat, 23 Jun 2012 15:25:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=51HWb0xQC3o2wR3i0toYdkmRWZBk44Xrcgx8bIgheEw=; b=BND1ed/DK+DYk0+wHVAItRdJ5hVQsr04J7p6rkCEu/EoGqfb3U1bCJkd70RaSZNCWk OKvdhnTEr4naqNuTGskzcAcDackcPxfB5vxWKysn7t8w4XNNGJcEsyvFIHM8P9kt5s4p ICpuBVcnE3NYtH+fKkEvppTelD9EMgRSx4D3c9kpnwmvAO0hVTj1sP/kmFM/raOt5Nd7 dmgG1jzCZKFU2s1xRyY7G8ZB8Zn4C45mFuUvjwCb+QUEtjVzxX4NaHMzjDV4DRk40fG3 Gh2iCbliTPguvSKb81kuBtlr16KXibcKEPUMNV+aVXxEjR2g94hHJ5xXn4EIzpgMjqyQ tOtQ== Received: by 10.52.99.138 with SMTP id eq10mr3464947vdb.25.1340490325438; Sat, 23 Jun 2012 15:25:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.99.138 with SMTP id eq10mr3464934vdb.25.1340490324961; Sat, 23 Jun 2012 15:25:24 -0700 (PDT) Received: by 10.52.168.99 with HTTP; Sat, 23 Jun 2012 15:25:24 -0700 (PDT) In-Reply-To: <87y5nfdpq7.fsf@fleche.redhat.com> References: <20120619074931.6F0B41E136F@ruffy2.mtv.corp.google.com> <87txy3f7wr.fsf@fleche.redhat.com> <87y5nfdpq7.fsf@fleche.redhat.com> Date: Sat, 23 Jun 2012 22:25:00 -0000 Message-ID: Subject: Re: [RFA] Add global/static and symbol kind indicator to .gdb_index From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org, ccoutant@google.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQmvFVjmXR4w697scwCECQpdS7gzPnJr5XaIZ3eAVnd4Ynco8uZjvgtTjhsZgndQ3wRnBDs1zqQBAtGeqY+0maHD6k6gMKSKwzemZr5VZFLaXZtlAyPxE7UR68uhzRR/RIV2bkR/Cp7+KD0vpVH8W1+nM2u3eeO12FCEjpcT0z1iWm3RQBJjciF5VnOvx9sA+8tgGN0E X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00744.txt.bz2 On Fri, Jun 22, 2012 at 2:02 PM, Tom Tromey wrote: >>>>>> "Tom" =3D=3D Tom Tromey writes: > > Doug> The global/static bit massively speeds up looking up things like > Doug> "int" when debugging with lots of shared libraries (all having > Doug> .gdb_index). =A0PR 14125 > > Tom> I don't think this patch is needed to achieve this. =A0At least, the= "int" > Tom> case and other similar cases were fixed by: > > Doug pointed out on irc that I was mistaken here. > The issue in his case is that, even though each individual index has a > single entry for "int", there are still many indices, so gdb still does > excessive CU expansion. > I'm sorry for the error. > > Tom> I think it is ok. > > At least this part still seems correct ;-) > > Tom Thanks. Committed with this NEWS entry. diff -u -p -r1.527 -r1.528 --- NEWS 6 Jun 2012 18:03:53 -0000 1.527 +++ NEWS 23 Jun 2012 22:23:46 -0000 1.528 @@ -112,6 +112,12 @@ the ability to set breakpoints on inlined functions will be lost in symbol files with older .gdb_index sections. + The .gdb_index section has also been updated to record more information + about each symbol. This speeds up the "info variables", "info functions" + and "info types" commands when used with programs having the .gdb_index + section, as well as speeding up debugging with shared libraries using + the .gdb_index section. + * Ada support for GDB/MI Variable Objects has been added. * GDB can now support 'breakpoint always-inserted mode' in 'record'