From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30918 invoked by alias); 22 Jun 2012 21:20:37 -0000 Received: (qmail 30910 invoked by uid 22791); 22 Jun 2012 21:20:36 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jun 2012 21:20:24 +0000 Received: by lbjn8 with SMTP id n8so4974006lbj.0 for ; Fri, 22 Jun 2012 14:20:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=BzOemx2iVkGqmTpxLt4xOMOpO1xAza99rqRwzkK0HrM=; b=MlsYv+/pcV74737EnZ/ApRkGFU853giZPurGpLf5F8qnRwsnIgY7FthRDL4WXeqTAA CS7g8N++WYRC/mImdSbDHfJAZpMm6KuqzJ+pDsOtxRRupAnxocf+HqMQsRfxfZxHFOsK eK0Z4QVCh/YPyhCxUQ93SuvY1xwJ3ljwLBe7WrttnGSiLuAAh/m5SNvZ64lTCy2n3Btn JFa8UBw6vp73F/Ve/9qZp6XsQ/zjZTA+2hX1pYtLpt9XHxmUgj4lq5scK8ljtBMrzLNx 3VzGMUc4+PplPu5XJF9SsPRxtUcn05lKuCtf9dBNqhZhUHC58j2BPLIou6yTEq57Y5B/ 1b7Q== Received: by 10.152.122.12 with SMTP id lo12mr3550876lab.3.1340400022585; Fri, 22 Jun 2012 14:20:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.122.12 with SMTP id lo12mr3550866lab.3.1340400022492; Fri, 22 Jun 2012 14:20:22 -0700 (PDT) Received: by 10.112.146.70 with HTTP; Fri, 22 Jun 2012 14:20:22 -0700 (PDT) In-Reply-To: <87y5nfdpq7.fsf@fleche.redhat.com> References: <20120619074931.6F0B41E136F@ruffy2.mtv.corp.google.com> <87txy3f7wr.fsf@fleche.redhat.com> <87y5nfdpq7.fsf@fleche.redhat.com> Date: Fri, 22 Jun 2012 21:20:00 -0000 Message-ID: Subject: Re: [RFA] Add global/static and symbol kind indicator to .gdb_index From: Cary Coutant To: Tom Tromey Cc: Doug Evans , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQnfXHJx6e6jSZEpnONPEGrpc9ATK2wdSSrBeFhRfnAXTUyk0ztr48v7DfS7vcFS3CbhpmZFXd0oHMmMeUB2L51JPAb26V1wSE5sec+83B+aEWUCSuqXPzvbPh3EY5NK9797vEzMlmKIRkZG4YAlEPHv5gGlOJTOMxJDod0j6ZxG8Mc5js8SheCZsTgTgqd0hmAeuI44 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00741.txt.bz2 > Doug> The global/static bit massively speeds up looking up things like > Doug> "int" when debugging with lots of shared libraries (all having > Doug> .gdb_index). =A0PR 14125 > > Tom> I don't think this patch is needed to achieve this. =A0At least, the= "int" > Tom> case and other similar cases were fixed by: > > Doug pointed out on irc that I was mistaken here. > The issue in his case is that, even though each individual index has a > single entry for "int", there are still many indices, so gdb still does > excessive CU expansion. > I'm sorry for the error. Is there still something I need to fix in gold in this regard? I think gold will produce an index entry for "int" in every CU that mentions it. If the right thing to do is to have only one CU, how do I decide what kinds of names get this treatment? (For example, some arbitrary type "struct foo" might actually be a different type, and you'd want multiple index entries.) -cary