Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable

[Yao Qi <qiyaoltc@gmail.com>]

On Thu, Jul 21, 2016 at 11:38 AM, Pedro Alves <palves@redhat.com> wrote:
> On 06/28/2016 04:02 PM, Yao Qi wrote:
>> On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey <tom@tromey.com> wrote:
>>> I built and regression tested this using --enable-targets=all on
>>> x86-64 Fedora 23.  However, I could not update the various nat-*
>>> files, so there are probably unfixed warnings lurking there.
>>
>> Can you use cross compiler to cross build native gdb to catch these warnings?
>> otherwise, once this patch series go in, gdb build on host other than linux may
>> be broken.
>
> The worse that can happen is a warning becomes a build error
> due to -Werror.  Since people can always use --disable-werror
> to work around it, and that is enabled by default in releases, I
> don't think a temporary -Werror build break on master is a major
> problem.
>
> What would you say would be a sufficient set of hosts to test before
> enabling a warning?
>
> Testing all supported hosts and all architectures would be unfeasible,
> naturally.

That isn't what I meant.  We need to cover the hosts we are able to, like
mingw, and unix machine we can access in gcc compile farm.

>
> I'd think it'd be acceptable to just build on a couple of the
> more common hosts, in the name of forward progress.
>

Yes, I agree.

-- 
Yao (齐尧)