From: Tom Tromey <tom@tromey.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Pedro Alves <palves@redhat.com>, Tom Tromey <tom@tromey.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable
Date: Thu, 21 Jul 2016 19:22:00 -0000 [thread overview]
Message-ID: <87vazyn6e2.fsf@tromey.com> (raw)
In-Reply-To: <CAH=s-PMS4gdD54W=mso31JKFgotyXh6uFo38BVvrFt8q4G2big@mail.gmail.com> (Yao Qi's message of "Thu, 21 Jul 2016 17:37:57 +0100")
>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
Yao> On Thu, Jul 21, 2016 at 4:18 PM, Pedro Alves <palves@redhat.com> wrote:
>> No build regressions on
>>
>> PPC64 GNU/Linux
>> S390 GNU/Linux
>> x64-64 NetBSD
>>
>> Any host missing? I think we're good to go.
>>
Yao> I don't think of any. Yes, please :)
I'll push the patch in momentarily. Feel free to ping me on any build
problems. I can't test them but I am happy to write a patch for someone
else to try.
There are a few more warnings that would be good to enable.
-Wmisleading-indentation (for me gdb is already clean here)
-Wduplicated-cond
-Wtautological-compare
I have a patch for a couple of problems pointed out by this, but there
is a larger one, https://sourceware.org/bugzilla/show_bug.cgi?id=20362
- a pretty big bug in arm_record_vfp_data_proc_insn.
It would be handy to have a "try" server on the buildbot to test patches
like this.
Tom
prev parent reply other threads:[~2016-07-21 19:22 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:34 Tom Tromey
2016-06-06 21:34 ` [RFA 3/6] Comment out some unused overlay code Tom Tromey
2016-06-28 14:36 ` Yao Qi
2016-06-28 20:56 ` Tom Tromey
2016-06-29 8:51 ` Yao Qi
2016-06-06 21:34 ` [RFA 6/6] Add -Wunused-but-set-* to build Tom Tromey
2016-06-08 2:30 ` Trevor Saunders
2016-06-08 2:46 ` Tom Tromey
2016-06-08 3:18 ` Trevor Saunders
2016-06-08 3:43 ` Tom Tromey
2016-06-08 4:16 ` Tom Tromey
2016-06-08 4:26 ` Trevor Saunders
2016-06-06 21:34 ` [RFA 1/6] Change reopen_exec_file to check result of stat Tom Tromey
2016-06-28 14:21 ` Yao Qi
2016-06-06 21:34 ` [RFA 5/6] Remove unused variables Tom Tromey
2016-06-28 14:50 ` Yao Qi
2016-06-28 20:57 ` Tom Tromey
2016-06-29 8:50 ` Yao Qi
2016-07-13 20:43 ` Tom Tromey
2016-07-14 7:30 ` Yao Qi
2016-07-20 18:37 ` Maciej W. Rozycki
2016-07-20 18:46 ` Paul_Koning
2016-07-21 23:41 ` Maciej W. Rozycki
2016-07-20 19:49 ` Tom Tromey
2016-07-25 13:36 ` Maciej W. Rozycki
2016-06-06 21:34 ` [RFA 4/6] Remove some variables but call functions for side effects Tom Tromey
2016-06-28 14:41 ` Yao Qi
2016-06-06 21:34 ` [RFA 2/6] Use ATTRIBUTE_UNUSED in some places Tom Tromey
2016-06-28 18:26 ` Pedro Alves
2016-06-28 20:58 ` Tom Tromey
2016-06-29 9:50 ` Pedro Alves
2016-06-28 15:02 ` [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable Yao Qi
2016-07-12 17:07 ` Tom Tromey
2016-07-13 13:45 ` Yao Qi
2016-07-14 16:49 ` Tom Tromey
2016-07-21 10:38 ` Pedro Alves
2016-07-21 11:10 ` Yao Qi
2016-07-21 11:35 ` Pedro Alves
2016-07-21 11:38 ` [PATCH 2/2] Remove unused variable in windows-nat.c Pedro Alves
2016-07-21 14:03 ` Yao Qi
2016-07-21 14:31 ` Pedro Alves
2016-07-21 11:38 ` [PATCH 1/2] Remove unused variable in gdb/varobj.c when built without Python support Pedro Alves
2016-07-21 14:01 ` Yao Qi
2016-07-21 14:31 ` Pedro Alves
2016-07-21 11:56 ` [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable Pedro Alves
2016-07-21 12:16 ` Pedro Alves
2016-07-21 14:47 ` Pedro Alves
2016-07-21 15:18 ` Pedro Alves
2016-07-21 16:38 ` Yao Qi
2016-07-21 19:22 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vazyn6e2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox