From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA 2/6] Use ATTRIBUTE_UNUSED in some places
Date: Mon, 06 Jun 2016 21:34:00 -0000 [thread overview]
Message-ID: <1465248812-23902-3-git-send-email-tom@tromey.com> (raw)
In-Reply-To: <1465248812-23902-1-git-send-email-tom@tromey.com>
A few spots needed ATTRIBUTE_UNUSED to cope with the new warnings.
In the TUI this happens due to the odd way that "getyx" works -- it
essentially uses references, so a variable must be passed in, even if
the code doesn't need to use it.
The case in inflow.c is just a mass of ifdefs; and while the only use
of "result" is guarded by "#if 0", I thought it simplest to leave it
all in place.
2016-06-06 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.c (tui_show_source_line): Use
ATTRIBUTE_UNUSED.
* tui/tui-io.c (tui_puts): Use ATTRIBUTE_UNUSED.
(tui_redisplay_readline): Likewise.
* inflow.c (child_terminal_ours_1): Use ATTRIBUTE_UNUSED.
---
gdb/ChangeLog | 8 ++++++++
gdb/inflow.c | 2 +-
gdb/tui/tui-io.c | 6 ++++--
gdb/tui/tui-winsource.c | 3 ++-
4 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 649bb0b..fbd7051 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
2016-06-06 Tom Tromey <tom@tromey.com>
+ * tui/tui-winsource.c (tui_show_source_line): Use
+ ATTRIBUTE_UNUSED.
+ * tui/tui-io.c (tui_puts): Use ATTRIBUTE_UNUSED.
+ (tui_redisplay_readline): Likewise.
+ * inflow.c (child_terminal_ours_1): Use ATTRIBUTE_UNUSED.
+
+2016-06-06 Tom Tromey <tom@tromey.com>
+
* corefile.c (reopen_exec_file): Only examine st.st_mtime if stat
succeeded.
diff --git a/gdb/inflow.c b/gdb/inflow.c
index 4c80dbd..9b94b29 100644
--- a/gdb/inflow.c
+++ b/gdb/inflow.c
@@ -419,7 +419,7 @@ child_terminal_ours_1 (int output_only)
pgrp. */
sighandler_t osigttou = NULL;
#endif
- int result;
+ int result ATTRIBUTE_UNUSED;
#ifdef SIGTTOU
if (job_control)
diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c
index 3fa32db..35025ce 100644
--- a/gdb/tui/tui-io.c
+++ b/gdb/tui/tui-io.c
@@ -172,7 +172,8 @@ tui_puts (const char *string)
/* Expand TABs, since ncurses on MS-Windows doesn't. */
if (c == '\t')
{
- int line, col;
+ int line ATTRIBUTE_UNUSED;
+ int col;
getyx (w, line, col);
do
@@ -198,7 +199,8 @@ tui_redisplay_readline (void)
{
int prev_col;
int height;
- int col, line;
+ int col;
+ int line ATTRIBUTE_UNUSED;
int c_pos;
int c_line;
int in;
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 48975b6..48bfbe4 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -273,7 +273,8 @@ static void
tui_show_source_line (struct tui_win_info *win_info, int lineno)
{
struct tui_win_element *line;
- int x, y;
+ int x;
+ int y ATTRIBUTE_UNUSED;
line = win_info->generic.content[lineno - 1];
if (line->which_element.source.is_exec_point)
--
2.5.5
next prev parent reply other threads:[~2016-06-06 21:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:34 [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable Tom Tromey
2016-06-06 21:34 ` [RFA 1/6] Change reopen_exec_file to check result of stat Tom Tromey
2016-06-28 14:21 ` Yao Qi
2016-06-06 21:34 ` [RFA 5/6] Remove unused variables Tom Tromey
2016-06-28 14:50 ` Yao Qi
2016-06-28 20:57 ` Tom Tromey
2016-06-29 8:50 ` Yao Qi
2016-07-13 20:43 ` Tom Tromey
2016-07-14 7:30 ` Yao Qi
2016-07-20 18:37 ` Maciej W. Rozycki
2016-07-20 18:46 ` Paul_Koning
2016-07-21 23:41 ` Maciej W. Rozycki
2016-07-20 19:49 ` Tom Tromey
2016-07-25 13:36 ` Maciej W. Rozycki
2016-06-06 21:34 ` [RFA 4/6] Remove some variables but call functions for side effects Tom Tromey
2016-06-28 14:41 ` Yao Qi
2016-06-06 21:34 ` Tom Tromey [this message]
2016-06-28 18:26 ` [RFA 2/6] Use ATTRIBUTE_UNUSED in some places Pedro Alves
2016-06-28 20:58 ` Tom Tromey
2016-06-29 9:50 ` Pedro Alves
2016-06-06 21:34 ` [RFA 3/6] Comment out some unused overlay code Tom Tromey
2016-06-28 14:36 ` Yao Qi
2016-06-28 20:56 ` Tom Tromey
2016-06-29 8:51 ` Yao Qi
2016-06-06 21:34 ` [RFA 6/6] Add -Wunused-but-set-* to build Tom Tromey
2016-06-08 2:30 ` Trevor Saunders
2016-06-08 2:46 ` Tom Tromey
2016-06-08 3:18 ` Trevor Saunders
2016-06-08 3:43 ` Tom Tromey
2016-06-08 4:16 ` Tom Tromey
2016-06-08 4:26 ` Trevor Saunders
2016-06-28 15:02 ` [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable Yao Qi
2016-07-12 17:07 ` Tom Tromey
2016-07-13 13:45 ` Yao Qi
2016-07-14 16:49 ` Tom Tromey
2016-07-21 10:38 ` Pedro Alves
2016-07-21 11:10 ` Yao Qi
2016-07-21 11:35 ` Pedro Alves
2016-07-21 11:38 ` [PATCH 1/2] Remove unused variable in gdb/varobj.c when built without Python support Pedro Alves
2016-07-21 14:01 ` Yao Qi
2016-07-21 14:31 ` Pedro Alves
2016-07-21 11:38 ` [PATCH 2/2] Remove unused variable in windows-nat.c Pedro Alves
2016-07-21 14:03 ` Yao Qi
2016-07-21 14:31 ` Pedro Alves
2016-07-21 11:56 ` [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable Pedro Alves
2016-07-21 12:16 ` Pedro Alves
2016-07-21 14:47 ` Pedro Alves
2016-07-21 15:18 ` Pedro Alves
2016-07-21 16:38 ` Yao Qi
2016-07-21 19:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465248812-23902-3-git-send-email-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox