From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68062 invoked by alias); 21 Jul 2016 19:22:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67979 invoked by uid 89); 21 Jul 2016 19:22:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 21 Jul 2016 19:22:25 +0000 Received: (qmail 16371 invoked by uid 0); 21 Jul 2016 19:22:23 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy6.mail.unifiedlayer.com with SMTP; 21 Jul 2016 19:22:23 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id MXNK1t00V2f2jeq01XNN26; Thu, 21 Jul 2016 13:22:23 -0600 X-Authority-Analysis: v=2.1 cv=LOD1Hvm9 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=C6ZbYQPAFpEA:10 a=cAmyUtKerLwA:10 a=pGLkceISAAAA:8 a=20KFwNOVAAAA:8 a=CCpqsmhAAAAA:8 a=CspDx36mwoZ6efwlqwYA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 a=e_O65bzb51kRm2y5VmPK:22 a=ul9cdbp4aOFLsgKbc677:22 Received: from [75.171.160.169] (port=48560 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bQJY3-0001bm-H9; Thu, 21 Jul 2016 13:22:19 -0600 From: Tom Tromey To: Yao Qi Cc: Pedro Alves , Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable References: <1465248812-23902-1-git-send-email-tom@tromey.com> <6a954e1a-ed72-fc02-b9b6-cce85e9b58e9@redhat.com> <7797fc3a-9651-3448-2def-3bc5b0c5cf55@redhat.com> <92e8008b-f140-4831-ebb8-f1371237c1cb@redhat.com> Date: Thu, 21 Jul 2016 19:22:00 -0000 In-Reply-To: (Yao Qi's message of "Thu, 21 Jul 2016 17:37:57 +0100") Message-ID: <87vazyn6e2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 75.171.160.169 authed with tom+tromey.com} X-Exim-ID: 1bQJY3-0001bm-H9 X-Source-Sender: (bapiya) [75.171.160.169]:48560 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-07/txt/msg00267.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> On Thu, Jul 21, 2016 at 4:18 PM, Pedro Alves wrote: >> No build regressions on >> >> PPC64 GNU/Linux >> S390 GNU/Linux >> x64-64 NetBSD >> >> Any host missing? I think we're good to go. >> Yao> I don't think of any. Yes, please :) I'll push the patch in momentarily. Feel free to ping me on any build problems. I can't test them but I am happy to write a patch for someone else to try. There are a few more warnings that would be good to enable. -Wmisleading-indentation (for me gdb is already clean here) -Wduplicated-cond -Wtautological-compare I have a patch for a couple of problems pointed out by this, but there is a larger one, https://sourceware.org/bugzilla/show_bug.cgi?id=20362 - a pretty big bug in arm_record_vfp_data_proc_insn. It would be handy to have a "try" server on the buildbot to test patches like this. Tom