From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50187 invoked by alias); 21 Jul 2016 11:10:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50136 invoked by uid 89); 21 Jul 2016 11:10:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 21 Jul 2016 11:10:39 +0000 Received: by mail-oi0-f53.google.com with SMTP id l72so112481714oig.2 for ; Thu, 21 Jul 2016 04:10:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7CAHt5BlSSUU6yGo296J+bsar6WgsWqBFZOf31tiDeQ=; b=mwXwQSnbYMUS5enyupLKGycrV2JvVqmWcTK1BOo0OhPHRr6CFMJ8XJY/0FQq90EIp6 f//qf9d2j0RfAY8RGhUdzmdcTCBB6eYn27W1b4sQc+VUvqU6jJiKqg4Ha47VvKfAd2wb LzgHN4QgIl9zOpjkWU7Pyt9qcc2/MLyWxA9O671Cj2vZyJKt7FMOpOhTLZ5L7cDYFiMS QPC7kF08OBGuE7AY80vPZfpym+pBQ/h3bw+D+fPaud1zLZieTqU1LdqlwNXK6rrx7iEX sveU/eTPvyd1GfhZciADndmAElj1kh58P7QfB1kY9eu4+D+Tc0q0UMMN3zMtDLv0KAoh LZSQ== X-Gm-Message-State: ALyK8tKNdsrh2MfdBJDgiwkEJpG94/jRslHbv3++YwdnxQVIcjEmSHIDVn4G0etbdQhwLZ9ieZhJlHJ5emIJCw== X-Received: by 10.157.60.228 with SMTP id t33mr29060019otf.163.1469099437949; Thu, 21 Jul 2016 04:10:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.105.138 with HTTP; Thu, 21 Jul 2016 04:10:37 -0700 (PDT) In-Reply-To: <6a954e1a-ed72-fc02-b9b6-cce85e9b58e9@redhat.com> References: <1465248812-23902-1-git-send-email-tom@tromey.com> <6a954e1a-ed72-fc02-b9b6-cce85e9b58e9@redhat.com> From: Yao Qi Date: Thu, 21 Jul 2016 11:10:00 -0000 Message-ID: Subject: Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable To: Pedro Alves Cc: Tom Tromey , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00242.txt.bz2 On Thu, Jul 21, 2016 at 11:38 AM, Pedro Alves wrote: > On 06/28/2016 04:02 PM, Yao Qi wrote: >> On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey wrote: >>> I built and regression tested this using --enable-targets=3Dall on >>> x86-64 Fedora 23. However, I could not update the various nat-* >>> files, so there are probably unfixed warnings lurking there. >> >> Can you use cross compiler to cross build native gdb to catch these warn= ings? >> otherwise, once this patch series go in, gdb build on host other than li= nux may >> be broken. > > The worse that can happen is a warning becomes a build error > due to -Werror. Since people can always use --disable-werror > to work around it, and that is enabled by default in releases, I > don't think a temporary -Werror build break on master is a major > problem. > > What would you say would be a sufficient set of hosts to test before > enabling a warning? > > Testing all supported hosts and all architectures would be unfeasible, > naturally. That isn't what I meant. We need to cover the hosts we are able to, like mingw, and unix machine we can access in gcc compile farm. > > I'd think it'd be acceptable to just build on a couple of the > more common hosts, in the name of forward progress. > Yes, I agree. --=20 Yao (=E9=BD=90=E5=B0=A7)