From: Yao Qi <qiyaoltc@gmail.com>
To: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Francois Bedard <Francois.Bedard@synopsys.com>,
Sergio Durigan Junior <sergiodj@redhat.com>
Subject: Re: [PATCH] Fix build breakage on MinGW due to missing setenv
Date: Mon, 03 Jul 2017 11:21:00 -0000 [thread overview]
Message-ID: <CAH=s-PO5oSxNCTFqqvK+f=4-q40c_soPii+MtonoKmP6capZpg@mail.gmail.com> (raw)
In-Reply-To: <20170703100258.15837-1-Anton.Kolesov@synopsys.com>
On Mon, Jul 3, 2017 at 11:02 AM, Anton Kolesov
<Anton.Kolesov@synopsys.com> wrote:
> Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide POSIX
> functions setenv () and unsetenv (), instead there is a putenv () wrapper
> around WinAPI function, although with a different signature.
>
> [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9a6c7d9c0
The better fix, IMO, is to use setenv and unsetenv
module in gnulib. However, I didn't check gnulib
manual about portability problems not fixed by gnulib.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-07-03 11:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 10:04 Anton Kolesov
2017-07-03 11:21 ` Yao Qi [this message]
2017-07-03 15:26 ` Sergio Durigan Junior
2017-07-03 16:27 ` [PATCH] Import setenv and unsetenv from gnulib Anton Kolesov
2017-07-03 19:35 ` Sergio Durigan Junior
2017-07-04 10:20 ` Yao Qi
2017-07-04 18:06 ` Anton Kolesov
[not found] ` <8737ac6j91.fsf@redhat.com>
2017-07-05 9:50 ` Anton Kolesov
2017-07-06 15:34 ` Sergio Durigan Junior
2017-07-05 9:56 ` Pedro Alves
2017-07-05 10:32 ` Anton Kolesov
2017-07-07 8:24 ` Yao Qi
2017-07-07 9:35 ` Anton Kolesov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PO5oSxNCTFqqvK+f=4-q40c_soPii+MtonoKmP6capZpg@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=Anton.Kolesov@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox