From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92859 invoked by alias); 3 Jul 2017 11:21:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92370 invoked by uid 89); 3 Jul 2017 11:21:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:D*synopsys.com X-HELO: mail-qk0-f196.google.com Received: from mail-qk0-f196.google.com (HELO mail-qk0-f196.google.com) (209.85.220.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jul 2017 11:21:04 +0000 Received: by mail-qk0-f196.google.com with SMTP id 16so23503167qkg.2 for ; Mon, 03 Jul 2017 04:21:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XpIn6t6cXHfU/NS4/bxiBChmC+O2quJHUJd9efmaFSA=; b=npOd4ahwXvbZ1ivr4umFZ07Fm+EBSvR/9BhmlSyKhKT0WDyxQNoc1zdn+8deTdh4oH kzZHLawr4iYCNBHjR2oFRCh//mGbQoqoZqvuhBB4As9niAHxD627qOvzCPraQo2aEf5u +Pg6JYo/KZanfd+A5c1YnrI2t1t4eVxz/RkSD8yLueJ9yJwiV+B/deo2TvoXCRdifoIU Nfzxlt3JR2LuNZsGk+QMxGQjiGLMq74ri3KKItTl5wYZIlGGx9q0UuXQdFOVyKt0AcuE AGB8Nd4dS1Rqxj5xo1O9SI5nUqIyGG7oNHW+QsOdqbkcB+4+K1+lAddYru6j+vHl2wIS xZhQ== X-Gm-Message-State: AKS2vOwWX7nuyJA3G6plKUEYaSwxcF1yX6Fq4FoNkPYtt4wleYBL4dgp UT/7iYgTLjhaZlX3ER/zpSJErMAe7w== X-Received: by 10.55.198.156 with SMTP id s28mr40830919qkl.222.1499080862778; Mon, 03 Jul 2017 04:21:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.142.67 with HTTP; Mon, 3 Jul 2017 04:21:02 -0700 (PDT) In-Reply-To: <20170703100258.15837-1-Anton.Kolesov@synopsys.com> References: <20170703100258.15837-1-Anton.Kolesov@synopsys.com> From: Yao Qi Date: Mon, 03 Jul 2017 11:21:00 -0000 Message-ID: Subject: Re: [PATCH] Fix build breakage on MinGW due to missing setenv To: Anton Kolesov Cc: "gdb-patches@sourceware.org" , Francois Bedard , Sergio Durigan Junior Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00010.txt.bz2 On Mon, Jul 3, 2017 at 11:02 AM, Anton Kolesov wrote: > Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide POS= IX > functions setenv () and unsetenv (), instead there is a putenv () wrapper > around WinAPI function, although with a different signature. > > [1] https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;h=3D9a6c7= d9c0 The better fix, IMO, is to use setenv and unsetenv module in gnulib. However, I didn't check gnulib manual about portability problems not fixed by gnulib. --=20 Yao (=E9=BD=90=E5=B0=A7)