Re: [PATCH] Import setenv and unsetenv from gnulib

Sergio Durigan Junior
2017-07-06T15:34:43Z

On Wednesday, July 05 2017, Anton Kolesov wrote:

>> >>
>> >> Did you run regression test on x86-linux? If there is no regression,
>> >> patches is good to me.
>> >
>> > If I run "make check-gdb", I don't see any obvious new errors from this
>> patch.
>> > Unfortunately results are a little bit volatile - some tests
>> > sporadically fail even if I run them with same GDB build and sources,
>> > even without this patch - I've run testsuite five times and got five similar,
>> but different results.
>>
>> Yeah, our testsuite has racy fails which are well known. What are the tests
>> that fail sporadically?
>
> - gdb.base/checkpoint-ns.exp: break
> - gdb.base/checkpoint.exp: break2 with many checkpoints
> - gdb.btrace/exception.exp: indented
> - Several consequtive tests in gdb.btrace/rn-dl-bind.exp

These don't ring any bells for me, but since you're testing on MingW, it
may very well be that they're racy tests on this platform as well. My
take is that if you can reproduce the exact failures without your patch,
then you can discard them as racy.

> - gdb.threads/process-dies-while-handling-bp.exp: non_stop=off (KFAIL became
> PASS with my patch).

This one is a known racy test.

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible