RE: [PATCH] Import setenv and unsetenv from gnulib

Anton Kolesov
2017-07-04T18:06:44Z

> > Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide
> > POSIX functions setenv () and unsetenv (). This can be fixed by using
> > implementations from gnulib.
> >
> > [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9a6c7d9c0
> >
>
> We need commit hash and subject only, like
>
> 9a6c7d9c0 (C++ify gdb/common/environ.c)
>
> Did you run regression test on x86-linux? If there is no regression, patches is
> good to me.

If I run "make check-gdb", I don't see any obvious new errors from this patch.
Unfortunately results are a little bit volatile - some tests sporadically fail even
if I run them with same GDB build and sources, even without this patch - I've run
testsuite five times and got five similar, but different results.

Selftests pass on x86_64-linux. On Windows with this patch there is a failure in
iconv sefltest, which seems unrelated (was present even when I've tried to use
putenv directly instead of importing gnulib module).

Anton

>
> --
> Yao (齐尧)