Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 Francois Bedard <Francois.Bedard@synopsys.com>,
	 Sergio Durigan Junior <sergiodj@redhat.com>
Subject: Re: [PATCH] Import setenv and unsetenv from gnulib
Date: Fri, 07 Jul 2017 08:24:00 -0000	[thread overview]
Message-ID: <86bmow64f6.fsf@gmail.com> (raw)
In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com>	(Anton Kolesov's message of "Tue, 4 Jul 2017 18:06:28 +0000")

Anton Kolesov <Anton.Kolesov@synopsys.com> writes:

> If I run "make check-gdb", I don't see any obvious new errors from this patch.
> Unfortunately results are a little bit volatile - some tests
> sporadically fail even
> if I run them with same GDB build and sources, even without this patch
> - I've run
> testsuite five times and got five similar, but different results.
>

They are not regressions to me.

> Selftests pass on x86_64-linux. On Windows with this patch there is a failure in
> iconv sefltest, which seems unrelated (was present even when I've tried to use
> putenv directly instead of importing gnulib module). 

Thanks for running tests on Windows.  Your patch is safe to go in.
Please push it in.

-- 
Yao (齐尧)


  parent reply	other threads:[~2017-07-07  8:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 10:04 [PATCH] Fix build breakage on MinGW due to missing setenv Anton Kolesov
2017-07-03 11:21 ` Yao Qi
2017-07-03 15:26   ` Sergio Durigan Junior
2017-07-03 16:27     ` [PATCH] Import setenv and unsetenv from gnulib Anton Kolesov
2017-07-03 19:35       ` Sergio Durigan Junior
2017-07-04 10:20       ` Yao Qi
2017-07-04 18:06         ` Anton Kolesov
     [not found]           ` <8737ac6j91.fsf@redhat.com>
2017-07-05  9:50             ` Anton Kolesov
2017-07-06 15:34               ` Sergio Durigan Junior
2017-07-05  9:56           ` Pedro Alves
2017-07-05 10:32             ` Anton Kolesov
2017-07-07  8:24           ` Yao Qi [this message]
2017-07-07  9:35             ` Anton Kolesov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bmow64f6.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=Anton.Kolesov@synopsys.com \
    --cc=Francois.Bedard@synopsys.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox