From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42916 invoked by alias); 7 Jul 2017 08:24:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37180 invoked by uid 89); 7 Jul 2017 08:24:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:786, H*r:sk:static., five X-HELO: mail-it0-f46.google.com Received: from mail-it0-f46.google.com (HELO mail-it0-f46.google.com) (209.85.214.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Jul 2017 08:24:04 +0000 Received: by mail-it0-f46.google.com with SMTP id m68so25133933ith.1 for ; Fri, 07 Jul 2017 01:24:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SOADPBWGxybV8wBoEXnS7LhjMdi26nlvhv3yNx0w9N8=; b=KF/1q0VtSZvhusSlBT1s/jdlCVVbVEdWsZrU7/VaPBb9IvchVzWrxp2YYzV4Di/K/w Y4A5oniO4VRX1T2LcAw+Asy1IgWSrW30YH/TKSYlf7WJIpJPt9N3xMmwP72tTI/xFVGy HczLJAd2sdw6xHn+2jR1Jc9CJufpvu+5aSe2zh35WiftNvvipfARn1Ol4O05zK5s++ad StbyNbEN4yOszSPbrDdPmY0BkW4C5TT8EP0DBLsssWb6j2QjnmzemMfOG9Tpfn5dB7xj EmvUEXWPsBXwS8osmiUdPrwbubNavxBoe2Zur0AOeN9UU+FsPo/eh6fgSDVYY7cCW9UH zcxA== X-Gm-Message-State: AIVw113odadKhG6hhcK+TVuvgCSeax6gPSlro4vvS3R/YmZLuYO2HQC2 1B9PkNSl8cHSwB+T X-Received: by 10.36.86.139 with SMTP id o133mr1671594itb.50.1499415842804; Fri, 07 Jul 2017 01:24:02 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id h196sm1372333ioe.41.2017.07.07.01.24.01 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 07 Jul 2017 01:24:02 -0700 (PDT) From: Yao Qi To: Anton Kolesov Cc: "gdb-patches\@sourceware.org" , Francois Bedard , Sergio Durigan Junior Subject: Re: [PATCH] Import setenv and unsetenv from gnulib References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> Date: Fri, 07 Jul 2017 08:24:00 -0000 In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> (Anton Kolesov's message of "Tue, 4 Jul 2017 18:06:28 +0000") Message-ID: <86bmow64f6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00041.txt.bz2 Anton Kolesov writes: > If I run "make check-gdb", I don't see any obvious new errors from this p= atch. > Unfortunately results are a little bit volatile - some tests > sporadically fail even > if I run them with same GDB build and sources, even without this patch > - I've run > testsuite five times and got five similar, but different results. > They are not regressions to me. > Selftests pass on x86_64-linux. On Windows with this patch there is a fai= lure in > iconv sefltest, which seems unrelated (was present even when I've tried t= o use > putenv directly instead of importing gnulib module).=20 Thanks for running tests on Windows. Your patch is safe to go in. Please push it in. --=20 Yao (=E9=BD=90=E5=B0=A7)