Re: ia64 build failure against master

Re: ia64 build failure against master

[Yao Qi]

On Thu, Mar 8, 2018 at 3:08 PM, Jason Duerstock
<jason.duerstock@gmail.com> wrote:
> I was trying to compile the latest source on ia64 and got this error:
>
> ../../gdb/ia64-tdep.c: In function ‘register_status
> ia64_pseudo_register_read(gdbarch*, readable_regcache*, int,
> gdb_byte*)’:
> ../../gdb/ia64-tdep.c:942:64: error: invalid conversion from
> ‘readable_regcache*’ to ‘regcache*’ [-fpermissive]
>     || libunwind_get_reg_special (gdbarch, regcache, regnum, buf) != 0)
>                                                                 ^
> In file included from ../../gdb/ia64-tdep.h:25:0,
>                  from ../../gdb/ia64-tdep.c:39:
> ../../gdb/ia64-libunwind-tdep.h:73:5: note:   initializing argument 2
> of ‘int libunwind_get_reg_special(gdbarch*, regcache*, int, void*)’
>  int libunwind_get_reg_special (struct gdbarch *gdbarch,
>      ^~~~~~~~~~~~~~~~~~~~~~~~~
> make[2]: *** [Makefile:1605: ia64-tdep.o] Error 1
> make[2]: Leaving directory '/mnt/b/native/binutils-gdb/build/gdb'
> make[1]: *** [Makefile:10421: all-gdb] Error 2
> make[1]: Leaving directory '/mnt/b/native/binutils-gdb/build'
> make: *** [Makefile:850: all] Error 2
>
> It looks related to commit 849d0ba8.  My system has libunwind installed.
>

I'll take a look.

-- 
Yao (齐尧)

[PATCH] Fix ia64 GDB build

[Yao Qi]

Commit 849d0ba8 breaks GDB build for ia64 with --with-libunwind-ia64=yes.
This patch fixes it.

Jason, does it unbreak your build?

gdb:

2018-03-09  Yao Qi  <yao.qi@linaro.org>

	* ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
	parameter type to readable_regcache.
	* ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
	the declaration.
---
 gdb/ia64-libunwind-tdep.c | 2 +-
 gdb/ia64-libunwind-tdep.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/ia64-libunwind-tdep.c b/gdb/ia64-libunwind-tdep.c
index 3ac613c..99782b2 100644
--- a/gdb/ia64-libunwind-tdep.c
+++ b/gdb/ia64-libunwind-tdep.c
@@ -452,7 +452,7 @@ libunwind_sigtramp_frame_sniffer (const struct frame_unwind *self,
    are usually located at BOF, this is not always true and only the libunwind
    info can decipher where they actually are.  */
 int
-libunwind_get_reg_special (struct gdbarch *gdbarch, struct regcache *regcache,
+libunwind_get_reg_special (struct gdbarch *gdbarch, readable_regcache *regcache,
 			   int regnum, void *buf)
 {
   unw_cursor_t cursor;
diff --git a/gdb/ia64-libunwind-tdep.h b/gdb/ia64-libunwind-tdep.h
index 5ac3a28..dc7ec9c 100644
--- a/gdb/ia64-libunwind-tdep.h
+++ b/gdb/ia64-libunwind-tdep.h
@@ -71,7 +71,7 @@ unw_word_t libunwind_find_dyn_list (unw_addr_space_t, unw_dyn_info_t *,
 				    void *);
 
 int libunwind_get_reg_special (struct gdbarch *gdbarch,
-			       struct regcache *regcache,
+			       readable_regcache *regcache,
 			       int regnum, void *buf);
 
 #endif /* IA64_LIBUNWIND_TDEP_H */
-- 
1.9.1

Re: [PATCH] Fix ia64 GDB build

[Jason Duerstock]

Yes, that fixes it.

Thanks,

Jason

On Fri, Mar 9, 2018 at 10:40 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Commit 849d0ba8 breaks GDB build for ia64 with --with-libunwind-ia64=yes.
> This patch fixes it.
>
> Jason, does it unbreak your build?
>
> gdb:
>
> 2018-03-09  Yao Qi  <yao.qi@linaro.org>
>
>         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
>         parameter type to readable_regcache.
>         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
>         the declaration.
> ---
>  gdb/ia64-libunwind-tdep.c | 2 +-
>  gdb/ia64-libunwind-tdep.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/ia64-libunwind-tdep.c b/gdb/ia64-libunwind-tdep.c
> index 3ac613c..99782b2 100644
> --- a/gdb/ia64-libunwind-tdep.c
> +++ b/gdb/ia64-libunwind-tdep.c
> @@ -452,7 +452,7 @@ libunwind_sigtramp_frame_sniffer (const struct frame_unwind *self,
>     are usually located at BOF, this is not always true and only the libunwind
>     info can decipher where they actually are.  */
>  int
> -libunwind_get_reg_special (struct gdbarch *gdbarch, struct regcache *regcache,
> +libunwind_get_reg_special (struct gdbarch *gdbarch, readable_regcache *regcache,
>                            int regnum, void *buf)
>  {
>    unw_cursor_t cursor;
> diff --git a/gdb/ia64-libunwind-tdep.h b/gdb/ia64-libunwind-tdep.h
> index 5ac3a28..dc7ec9c 100644
> --- a/gdb/ia64-libunwind-tdep.h
> +++ b/gdb/ia64-libunwind-tdep.h
> @@ -71,7 +71,7 @@ unw_word_t libunwind_find_dyn_list (unw_addr_space_t, unw_dyn_info_t *,
>                                     void *);
>
>  int libunwind_get_reg_special (struct gdbarch *gdbarch,
> -                              struct regcache *regcache,
> +                              readable_regcache *regcache,
>                                int regnum, void *buf);
>
>  #endif /* IA64_LIBUNWIND_TDEP_H */
> --
> 1.9.1
>

Re: [PATCH] Fix ia64 GDB build

[Yao Qi]

On Fri, Mar 9, 2018 at 5:49 PM, Jason Duerstock
<jason.duerstock@gmail.com> wrote:
> Yes, that fixes it.
>

Patch is pushed in.

-- 
Yao (齐尧)