From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76538 invoked by alias); 9 Mar 2018 17:49:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76088 invoked by uid 89); 9 Mar 2018 17:49:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-vk0-f67.google.com Received: from mail-vk0-f67.google.com (HELO mail-vk0-f67.google.com) (209.85.213.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 17:49:28 +0000 Received: by mail-vk0-f67.google.com with SMTP id y127so2614001vky.9 for ; Fri, 09 Mar 2018 09:49:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zaIJt+kaD1B8NO/gm24yx7w9D9DjzgVXJZvW0qSDrlw=; b=AX+bcarTnYsehrHTclsl3/I/2J9ByAJWCF8kG70Uh1B5UQUCiryR7bqZ/BTpk/uPoM F1RNXLZhby8v6ElI4/+mY/+ehMc01K9g0miaPrITFMEYX4QaGvCeQWPac0gIMNdlja0V pk7q6bPUgg9be1D1UkjE2aTH4NQWD1JulTpCj8+rqWwiUANOgnEo5GI+fWLNqZfdC3hn qc+pzkrwPaeDe+pbw3HBMHRWBLsHR9nCBeaB5kOXxHpd4HEZlUHgrRvh5aKibaKNMSoN XL31YdXqUlg9cCN7hNhVmAEjzoyttc3Wh1pEXEKVHh4cdnFQcfmPP3/1ItuKjcRI7/Nt /QFQ== X-Gm-Message-State: APf1xPCDbxL7nVXNb2/LZcgmW0kFVfV/rvFogiylf9+hDjY4OvyrNf4f EsW5pItSWT6NgCiOP37xmiHe/GUgO8QBjR0SKwg= X-Google-Smtp-Source: AG47ELuQ65hlzZaqyrh1iRHYQ7jT+icUlcr6Nje6PHU34Vv5VjDkc2a+v0MkFq0I4igAnZ+Rrq4tn+UowbZwWH7Q3ag= X-Received: by 10.31.107.145 with SMTP id k17mr22307960vki.198.1520617765979; Fri, 09 Mar 2018 09:49:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.70.10 with HTTP; Fri, 9 Mar 2018 09:49:25 -0800 (PST) In-Reply-To: <1520610015-18719-1-git-send-email-yao.qi@linaro.org> References: <1520610015-18719-1-git-send-email-yao.qi@linaro.org> From: Jason Duerstock Date: Fri, 09 Mar 2018 17:49:00 -0000 Message-ID: Subject: Re: [PATCH] Fix ia64 GDB build To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-03/txt/msg00201.txt.bz2 Yes, that fixes it. Thanks, Jason On Fri, Mar 9, 2018 at 10:40 AM, Yao Qi wrote: > Commit 849d0ba8 breaks GDB build for ia64 with --with-libunwind-ia64=yes. > This patch fixes it. > > Jason, does it unbreak your build? > > gdb: > > 2018-03-09 Yao Qi > > * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change > parameter type to readable_regcache. > * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update > the declaration. > --- > gdb/ia64-libunwind-tdep.c | 2 +- > gdb/ia64-libunwind-tdep.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/ia64-libunwind-tdep.c b/gdb/ia64-libunwind-tdep.c > index 3ac613c..99782b2 100644 > --- a/gdb/ia64-libunwind-tdep.c > +++ b/gdb/ia64-libunwind-tdep.c > @@ -452,7 +452,7 @@ libunwind_sigtramp_frame_sniffer (const struct frame_unwind *self, > are usually located at BOF, this is not always true and only the libunwind > info can decipher where they actually are. */ > int > -libunwind_get_reg_special (struct gdbarch *gdbarch, struct regcache *regcache, > +libunwind_get_reg_special (struct gdbarch *gdbarch, readable_regcache *regcache, > int regnum, void *buf) > { > unw_cursor_t cursor; > diff --git a/gdb/ia64-libunwind-tdep.h b/gdb/ia64-libunwind-tdep.h > index 5ac3a28..dc7ec9c 100644 > --- a/gdb/ia64-libunwind-tdep.h > +++ b/gdb/ia64-libunwind-tdep.h > @@ -71,7 +71,7 @@ unw_word_t libunwind_find_dyn_list (unw_addr_space_t, unw_dyn_info_t *, > void *); > > int libunwind_get_reg_special (struct gdbarch *gdbarch, > - struct regcache *regcache, > + readable_regcache *regcache, > int regnum, void *buf); > > #endif /* IA64_LIBUNWIND_TDEP_H */ > -- > 1.9.1 >