Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jason Duerstock <jason.duerstock@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix ia64 GDB build
Date: Fri, 09 Mar 2018 17:49:00 -0000	[thread overview]
Message-ID: <CAP5F8c+X8YD5oAQVXyDvoRijMeBQL-zn7uMggMYjaexOrztZUw@mail.gmail.com> (raw)
In-Reply-To: <1520610015-18719-1-git-send-email-yao.qi@linaro.org>

Yes, that fixes it.

Thanks,

Jason

On Fri, Mar 9, 2018 at 10:40 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Commit 849d0ba8 breaks GDB build for ia64 with --with-libunwind-ia64=yes.
> This patch fixes it.
>
> Jason, does it unbreak your build?
>
> gdb:
>
> 2018-03-09  Yao Qi  <yao.qi@linaro.org>
>
>         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
>         parameter type to readable_regcache.
>         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
>         the declaration.
> ---
>  gdb/ia64-libunwind-tdep.c | 2 +-
>  gdb/ia64-libunwind-tdep.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/ia64-libunwind-tdep.c b/gdb/ia64-libunwind-tdep.c
> index 3ac613c..99782b2 100644
> --- a/gdb/ia64-libunwind-tdep.c
> +++ b/gdb/ia64-libunwind-tdep.c
> @@ -452,7 +452,7 @@ libunwind_sigtramp_frame_sniffer (const struct frame_unwind *self,
>     are usually located at BOF, this is not always true and only the libunwind
>     info can decipher where they actually are.  */
>  int
> -libunwind_get_reg_special (struct gdbarch *gdbarch, struct regcache *regcache,
> +libunwind_get_reg_special (struct gdbarch *gdbarch, readable_regcache *regcache,
>                            int regnum, void *buf)
>  {
>    unw_cursor_t cursor;
> diff --git a/gdb/ia64-libunwind-tdep.h b/gdb/ia64-libunwind-tdep.h
> index 5ac3a28..dc7ec9c 100644
> --- a/gdb/ia64-libunwind-tdep.h
> +++ b/gdb/ia64-libunwind-tdep.h
> @@ -71,7 +71,7 @@ unw_word_t libunwind_find_dyn_list (unw_addr_space_t, unw_dyn_info_t *,
>                                     void *);
>
>  int libunwind_get_reg_special (struct gdbarch *gdbarch,
> -                              struct regcache *regcache,
> +                              readable_regcache *regcache,
>                                int regnum, void *buf);
>
>  #endif /* IA64_LIBUNWIND_TDEP_H */
> --
> 1.9.1
>


  reply	other threads:[~2018-03-09 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAP5F8c+oi50ds7iqmbkfRgEuJjwOLfUe_TsackBwso3FwQreBQ@mail.gmail.com>
2018-03-08 16:08 ` ia64 build failure against master Yao Qi
2018-03-09 15:40   ` [PATCH] Fix ia64 GDB build Yao Qi
2018-03-09 17:49     ` Jason Duerstock [this message]
2018-03-12  9:18       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP5F8c+X8YD5oAQVXyDvoRijMeBQL-zn7uMggMYjaexOrztZUw@mail.gmail.com \
    --to=jason.duerstock@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox