From: Siva Chandra <sivachandra@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Doug Evans <dje@google.com>,
uweigand@de.ibm.com
Subject: Re: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4
Date: Wed, 04 Jun 2014 20:53:00 -0000 [thread overview]
Message-ID: <CAGyQ6gzpHfaAeJ1q_Q71Y00K9kLfbEVnb=Y=30cSLaK0RuBv1A@mail.gmail.com> (raw)
In-Reply-To: <538F7A06.4040108@redhat.com>
On Wed, Jun 4, 2014 at 12:56 PM, Pedro Alves <palves@redhat.com> wrote:
> On 06/04/2014 07:05 PM, Siva Chandra wrote:
>> Does the attached patch fix the issue pointed out by Ulrich Weigand
>> here: https://sourceware.org/ml/gdb-patches/2014-06/msg00169.html
>>
>> ChangeLog
>> 2014-06-04 Siva Chandra Reddy <sivachandra@google.com>
>>
>> * python/py-xmethods.c (invoke_match_method)
>> (gdbpy_get_matching_xmethod_workers, gdbpy_get_xmethod_arg_types):
>> Cast the second arg to PyObject_GetAttrString and
>> PyObject_GetAttrString to char *.
>>
>
> How about we handle this in a central place, like Py_DECREF is
> handled ? See python-internal.h.
This breakage was marked as "nice to have it fixed" for 7.8.
Considering that, do you prefer that we have a Py_DECREF like solution
now, or after 7.8 branching?
next prev parent reply other threads:[~2014-06-04 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 18:05 Siva Chandra
2014-06-04 18:13 ` Joel Brobecker
2014-06-04 18:25 ` Siva Chandra
2014-06-04 19:24 ` Joel Brobecker
2014-06-04 19:23 ` Doug Evans
2014-06-04 19:57 ` Pedro Alves
2014-06-04 20:53 ` Siva Chandra [this message]
2014-06-04 21:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyQ6gzpHfaAeJ1q_Q71Y00K9kLfbEVnb=Y=30cSLaK0RuBv1A@mail.gmail.com' \
--to=sivachandra@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox